feat!: use packaging.Version and other fixes and Ape-ifications
#161
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
antazoey
force-pushed
the
chore/conformity
branch
10 times, most recently
from
93e04b3 to
95ab54d
Compare
antazoey
changed the title
packaging.Version and other updatespackaging.Version and other fixes
antazoey
changed the title
packaging.Version and other fixespackaging.Version and other fixes and Ape-ifications
antazoey
force-pushed
the
chore/conformity
branch
5 times, most recently
from
09463f2 to
09af34b
Compare
antazoey
force-pushed
the
chore/conformity
branch
from
09af34b to
803b409
Compare
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
Glad your adding this, opening a PR on the project-template now.
antazoey
force-pushed
the
chore/conformity
branch
from
803b409 to
0cfc55b
Compare
| @@ -21,14 +21,18 @@ def solc_binary(): | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def nosolc(tmp_path, monkeypatch): | |||
| def nosolc(tmp_path, mocker): | |||
There was a problem hiding this comment.
ya mocker is built on top of monkeypatch but i find its syntax easier to read in some cases.
Co-authored-by: NotPeopling2day <32708219+NotPeopling2day@users.noreply.github.com>
What I did
Major dust off of this package to try and get it moving again.
semantic_versiontopackaging.Versionto properly handle RC versions.--helpcommand expected the wrong result code for some solc versionsfixes: #145
fixes: #147
How I did it
How to verify it
Checklist