Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to built-in setuptools functionality #154

Closed
wants to merge 1 commit into from

Conversation

lemenkov
Copy link

@lemenkov lemenkov commented Oct 31, 2022

Looks like setuptools-markdown is deprecated in favor of a built-in setuptools functionality. Worse is that setuptools_markdown isn't compatible with a recent versions of a pypandoc library. Let's just drop it.

What I did

Related issue: man-group/pytest-plugins#87

How I did it

Stumbled upon this message while building:

/usr/bin/python3 setup.py build '--executable=/usr/bin/python3 -sP'
/usr/lib/python3.11/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
  warnings.warn(
Traceback (most recent call last):
  File "/home/petro/rpmbuild/BUILD/py-solc-x-1.1.1/setup.py", line 5, in <module>
    setup(
  File "/usr/lib/python3.11/site-packages/setuptools/__init__.py", line 87, in setup
    return distutils.core.setup(**attrs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 139, in setup
    _setup_distribution = dist = klass(attrs)
                                 ^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/setuptools/dist.py", line 477, in __init__
    _Distribution.__init__(
  File "/usr/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 275, in __init__
    self.finalize_options()
  File "/usr/lib/python3.11/site-packages/setuptools/dist.py", line 901, in finalize_options
    ep(self)
  File "/usr/lib/python3.11/site-packages/setuptools/dist.py", line 922, in _finalize_setup_keywords
    ep.load()(self, ep.name, value)
  File "/home/petro/rpmbuild/BUILD/py-solc-x-1.1.1/.eggs/setuptools_markdown-0.4.1-py3.11.egg/setuptools_markdown.py", line 43, in long_description_markdown_filename
    output = pypandoc.convert(markdown_filename, 'rst', format='md')
             ^^^^^^^^^^^^^^^^
AttributeError: module 'pypandoc' has no attribute 'convert'

How to verify it

Run with a recent pypandoc. It will throw something like "AttributeError: module 'pypandoc' has no attribute 'convert'"

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation (README.md)
  • I have added an entry to the changelog

Looks like setuptools-markdown is deprecated in favor of a built-in
setuptools functionality. Worse is that setuptools_markdown isn't
compatible with a recent versions of a pypandoc library. Let's just drop
it.

See also man-group/pytest-plugins#87.

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
@lemenkov lemenkov force-pushed the drop_setuptools_markdown branch from a717f9e to b1eb3df Compare October 31, 2022 21:49
@lemenkov lemenkov changed the title Switch to built-in setuptols functionality Switch to built-in setuptools functionality Oct 31, 2022
@antazoey
Copy link
Member

antazoey commented Nov 9, 2023

Completed in #161 as part of the general Ape-ifications

@antazoey antazoey closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants