Fixes issues #145 and #147 #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `pragma_string="pragma solidity =0.6.11 >=0.6.0 <0.8.0 >=0.6.2 <0.8.0;"`, the expression `comparator_regex.findall(comparator_set)` returns only a single match, `[('<0.8.0', '<')]`, instead of `[('=0.6.11', '='), ('>=0.6.0', '>='), ('<0.8.0', '<'), ('>=0.6.2', '>='), ('<0.8.0', '<')]`. The reason is the extra `+` operator in the expression.
The Solidity compiler accepts version numbers like `0.5.01`, whereas `semantic_version` does not. To keep `py-solc-x` compatible with the way `solc` parses versions, we remove leading zeros before handing the information over to semantic_version.
When handing over a list of versions specifications to SimpleSpec, these of the be separated by commas
This was referenced Mar 27, 2022
Locks acquired by one user when downloading a compiler will prevent other users from doing the same, because the name of the lock file depends only on the solc version, but not on the user id, and the lock file is owned by the first user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modified the parsing of the pragma string in order to
>=0.5.4 <=0.5.9Related issue: #145 #147
Checklist