-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use packaging.Version
and other fixes and Ape-ifications
#161
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,24 @@ | ||
--- | ||
name: Bug Report | ||
name: Bug report | ||
about: Report an error that you've encountered. | ||
labels: bug | ||
--- | ||
|
||
### Environment information | ||
|
||
* `py-solc-x` Version: x.x.x | ||
* `solc` Version: x.x.x | ||
* Python Version: x.x.x | ||
* OS: osx/linux/win | ||
- `py-solc-x` Version: x.x.x | ||
- `solc` Version: x.x.x | ||
- Python Version: x.x.x | ||
- OS: macOS/linux/win | ||
|
||
### What was wrong? | ||
### What went wrong? | ||
|
||
Please include information like: | ||
|
||
* what command you ran | ||
* the code that caused the failure (see [this link](https://help.github.com/articles/basic-writing-and-formatting-syntax/) for help with formatting code) | ||
* full output of the error you received | ||
- what command you ran | ||
- the code that caused the failure (see [this link](https://help.github.com/articles/basic-writing-and-formatting-syntax/) for help with formatting code) | ||
- full output of the error you received | ||
|
||
### How can it be fixed? | ||
|
||
Fill this in if you know how the bug could be fixed. | ||
Fill this in if you have ideas on how the bug could be fixed. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,22 @@ | ||
--- | ||
name: Feature Request | ||
name: Feature request | ||
about: Request a new feature, or an improvement to existing functionality. | ||
labels: enhancement | ||
--- | ||
|
||
### Overview | ||
|
||
Provide a simple overview of what you wish to see added. Please include: | ||
|
||
* What you are trying to do | ||
* Why solcx's current functionality is inadequate to address your goal | ||
- What you are trying to do | ||
- Why solcx's current functionality is inadequate to address your goal | ||
|
||
### Specification | ||
|
||
Describe the syntax and semantics of how you would like to see this feature implemented. The more detailed the better! | ||
|
||
Remember, your feature is much more likely to be included if it does not involve any breaking changes. | ||
|
||
### Dependencies | ||
|
||
Include links to any open issues that must be resolved before this feature can be implemented. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
--- | ||
name: Work item | ||
about: New work item for Ape team | ||
labels: backlog | ||
--- | ||
|
||
### Elevator pitch: | ||
|
||
<!-- 1-2 line summary of the scope of this work item --> | ||
|
||
### Value: | ||
|
||
<!-- | ||
Who is this for? | ||
Persona or group of people whom will derive value from the scenario. | ||
What benefits will be achieved or business metrics improved? | ||
--> | ||
|
||
### Dependencies: | ||
|
||
<!-- Call out key people, teams, tech dependencies, or assumptions. --> | ||
|
||
### Design approach: | ||
|
||
<!-- | ||
Free text / diagram / whiteboard picture / etc. that clearly shows your approach and considerations to build the task list. | ||
Existing code patterns in production code base that you will base your work off of. | ||
--> | ||
|
||
### Task list: | ||
|
||
<!-- Bulleted list describing the exit criteria, desired end state and any documentation, monitors, work for DRI, etc. that will need to be added to make sure someone else can support once it's live. --> | ||
|
||
- [ ] Tasks go here | ||
|
||
### Estimated completion date: | ||
|
||
### Design review: | ||
|
||
<!-- 1-2 people needed for signoff --> | ||
|
||
Do not signoff unless: | ||
|
||
- 1. agreed the tasks and design approach will achieve acceptance, and | ||
- 2. the work can be completed by one person within the SLA. | ||
Design reviewers should consider simpler approaches to achieve goals. | ||
|
||
(Please leave a comment to sign off) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,16 @@ | ||
### What I did | ||
|
||
Related issue: # | ||
<!-- The `fixes:` field denotes an issue that will be marked resolved by merging this PR --> | ||
|
||
fixes: # | ||
|
||
### How I did it | ||
|
||
### How to verify it | ||
|
||
### Checklist | ||
|
||
- [ ] I have confirmed that my PR passes all linting checks | ||
- [ ] I have included test cases | ||
- [ ] I have updated the documentation (README.md) | ||
- [ ] I have added an entry to the changelog | ||
- [ ] Passes all linting checks (pre-commit and CI jobs) | ||
- [ ] New test cases have been added and are passing | ||
- [ ] Documentation has been updated | ||
- [ ] PR title follows [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) standard (will be automatically included in the changelog) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
name: "CodeQL" | ||
|
||
on: | ||
push: | ||
branches: [ "main" ] | ||
pull_request: | ||
branches: [ "main" ] | ||
|
||
jobs: | ||
analyze: | ||
name: Analyze | ||
runs-on: ubuntu-latest | ||
permissions: | ||
actions: read | ||
contents: read | ||
security-events: write | ||
|
||
strategy: | ||
fail-fast: false | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v3 | ||
|
||
- name: Initialize CodeQL | ||
uses: github/codeql-action/init@v2 | ||
with: | ||
languages: python | ||
|
||
- name: Autobuild | ||
uses: github/codeql-action/autobuild@v2 | ||
|
||
- name: Perform CodeQL Analysis | ||
uses: github/codeql-action/analyze@v2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
name: Release Drafter | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
update-draft: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write | ||
steps: | ||
# Drafts your next Release notes as Pull Requests are merged into "master" | ||
- uses: release-drafter/release-drafter@v5 | ||
with: | ||
disable-autolabeler: true | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: PR Title | ||
|
||
on: | ||
pull_request_target: | ||
types: | ||
- opened | ||
- edited | ||
- synchronize | ||
|
||
jobs: | ||
check: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Setup Python | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: "3.10" | ||
|
||
- name: Install Dependencies | ||
run: pip install commitizen | ||
|
||
- name: Check PR Title | ||
env: | ||
TITLE: ${{ github.event.pull_request.title }} | ||
run: cz check --message "$TITLE" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: Release | ||
|
||
on: | ||
release: | ||
types: [released] | ||
|
||
jobs: | ||
deploy: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: "3.10" | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install -e .[release] | ||
- name: Build | ||
run: python setup.py sdist bdist_wheel | ||
|
||
- name: Publish | ||
env: | ||
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }} | ||
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }} | ||
run: twine upload dist/* --verbose |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad your adding this, opening a PR on the project-template now.