drop Node 16 (EOL) #8365

turadg · 2023-09-21T17:23:22Z

Description

See https://nodejs.dev/en/about/releases/

Node v16 hit EOL on Sep 11. This ~~drops it from matrix testing and~~ narrows engines from >14 to LTS.

~~It adds a .node-version file for those using tools like https://github.com/nodenv (multiple tools observe the file).~~

The stricken parts were done in other PRs.

Security Considerations

Dropping unsupported versions should remove risks of exploits

Scaling Considerations

n/a

Documentation Considerations

https://docs.agoric.com/guides/getting-started/ already says to use an LTS version.

Testing Considerations

CI

Upgrade Considerations

Consumers using Node 14 or 16 will have to upgrade to 18.

mhofman · 2023-09-21T17:25:13Z

.github/workflows/integration.yml

@@ -61,7 +61,7 @@ jobs:
      # Prerequisites
      - uses: ./.github/actions/restore-node
        with:
-          node-version: 16.x
+          node-version: 18.x


Didn't realize we were still on Node 16 here!

This may be breaking the "getting-started" integration test.

cc @LuqiPan who is currently working on updating this test.

This is actually what we need to do: https://github.com/Agoric/agoric-sdk/pull/8829/files#diff-82454b2fc887e9985b9348b8f3bca03d2f839645a4c3ba1f3f850014d7da5c8bL60

Ah yeah, pinning this at 18.18 might be the way to unblock for now. I'd like to get our dapps to handle node 18.19, but that's another story.

mhofman · 2023-09-21T17:27:07Z

Do we actually need to already drop Node 16? Since this change needs to be synchronized with a change to GH required checks (manual process), and kinda wanted to only do this once when Node 20 gets LTS in a few weeks

turadg · 2023-09-21T17:49:36Z

Do we actually need to already drop Node 16? Since this change needs to be synchronized with a change to GH required checks (manual process), and kinda wanted to only do this once when Node 20 gets LTS in a few weeks

Technically there are about six weeks while 18 is the only LTS. I'm fine with doing the drop 16 at the same time as add 20, though either way we're fudging on what LTS is.

Regarding GH checks, it's rare that we have an error in one Node and not the other. Why don't we drop the 16 checks now and when 20 is running in CI we enable those? That would reduce the need to rerun CI on open PRs.

erights · 2023-09-22T00:12:24Z

What about Endo?

mhofman

LGTM. Can you update the title and description to indicate this is adding Node 20?

Also we'll need to synchronize the update of branch protections

mhofman · 2023-12-05T16:59:32Z

package.json

@@ -37,7 +37,7 @@
    "typescript": "~5.3.2"
  },
  "engines": {
-    "node": "^16.13 || ^18.12"
+    "node": "^18.12 || ^20.9"


mhofman · 2023-12-05T17:04:54Z

Oh yikes, looks like bufferfromfile is not compatible with node >19

mhofman · 2023-12-05T17:07:26Z

Oh we already have a fork, maybe we can patch it there. Upstream looks unmaintained.

turadg · 2023-12-05T18:43:47Z

Upstream looks unmaintained.

Agreed, Wandalen/BufferFromFile#53

we already have a fork, maybe we can patch it there.

https://github.com/agoric-labs/BufferFromFile I'll take a crack at it.

turadg · 2023-12-08T16:48:52Z

Since Node 20 is blocked on the Bufferfile problem, @mhofman are you open now to dropping Node 16 without adopting 20? 16 is EOL so there's no point supporting it.

mhofman · 2023-12-08T16:50:54Z

For master I think that's ok. For the release branch I'd be more reticent.

turadg · 2023-12-08T23:24:39Z

Integration errors below. In hindsight, when we have have a range of versions supported but only integrate with one, perhaps we should always integrate with the active LTS so that when it becomes the maintenance LTS we know it works.

deployment-test (Loadgen)

failed to delete intrinsics.Symbol.dispose (TypeError#1)
TypeError#1: Cannot delete property 'dispose' of function Symbol() { [native code] }

(TypeError#1)
Error: Process completed with exit code 255.

getting-started (all)

  Difference (- actual, + expected):

  - 'too many retries'
  + 'listening'

  › gettingStartedWorkflowTest (packages/agoric-cli/tools/getting-started.js:247:7)

I don't see any earlier errors in the log. Maybe it's an API change?

erights · 2023-12-08T23:57:55Z

failed to delete intrinsics.Symbol.dispose (TypeError#1)
TypeError#1: Cannot delete property 'dispose' of function Symbol() { [native code] }

This is a symptom of a problem fixed in endo ages ago:

endojs/endo#1578 merged May 4

endojs/endo#1579 merged May 30

which, IIUC, is well before the endo release that agoric_sdk currently depends on.

Where is this error coming from? What version of endo is it using?

mhofman · 2023-12-09T00:28:07Z

Oh the loadgen dapp might be relying on an old Endo version. We likely need to fix other dapps first too.

mhofman · 2023-12-09T00:29:19Z

FYI this Node 18 breakage is very recent (late November release), qnd has been trickling out this week.

github-actions · 2023-12-10T08:00:29Z

@turadg - This PR appears to be stuck. It's had a merge label for > 24 hours

turadg · 2023-12-10T16:29:37Z

this Node 18 breakage is very recent (late November release

Are you saying 18.19 introduced the breakage and 18.18 should work? It's not in #8638

mhofman · 2023-12-10T17:15:28Z

Are you saying 18.19 introduced the breakage and 18.18 should work? It's not in #8638

Correct. Node 18.19 introduced a breaking change to old versions of Endo / SES. agoric-sdk has long updated SES, but we were only testing dapps in Node 16

turadg · 2023-12-11T16:30:27Z

I think the 18.19 change is just what #8600 fixes. There's some other failure in getting-started (referenced above) but that's not a required check so this could land and we could follow up fixing that.

For the 18.19, the patch against ses 0.18.4 isn't applying cleanly against 0.18.8. @kriskowal should we repatch or wait for Endo to be updated?

Sync Endo 2023-11 #8514

mhofman · 2023-12-11T17:17:05Z

#8600 is not necessary on master since the version of SES on master already includes that fix.

github-actions · 2023-12-13T08:00:29Z

@turadg - This PR appears to be stuck. It's had a merge label for > 24 hours

mhofman

Couple small tweaks needed. I added the force:integration label to see how integration tests run with this change. Also please manually rebase this PR on top of the latest master before merging, mergify and our CI checks have a limitation not enforcing our linear history rule when a merge commit exists in the branch.

yarn.lock

mhofman · 2024-01-29T19:59:48Z

packages/create-dapp/package.json

-  "engines": {
-    "node": "^18.12"


I'm thinking the create-dapp package actually should keep an engines field like the other packages

0xpatrickdev · 2024-01-29T22:17:28Z

I think #8829 is the last piece before this can pass. CI seems to be failing due to the dependency on dapp-fungible-faucet

mhofman · 2024-01-29T22:22:57Z

I think #8829 is the last piece before this can pass. CI seems to be failing due to the dependency on dapp-fungible-faucet

I would not block on that PR, and maybe force node 18.18 on that workflow instead?

LuqiPan

LGTM

erights · 2024-03-13T22:26:13Z

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop Node 16 (EOL) #8365

drop Node 16 (EOL) #8365

turadg commented Sep 21, 2023 •

edited

Loading

mhofman Sep 21, 2023

mhofman Jan 29, 2024 •

edited

Loading

LuqiPan Jan 29, 2024

mhofman Jan 29, 2024

mhofman commented Sep 21, 2023

turadg commented Sep 21, 2023

erights commented Sep 22, 2023

mhofman left a comment

mhofman Dec 5, 2023

mhofman commented Dec 5, 2023

mhofman commented Dec 5, 2023 •

edited

Loading

turadg commented Dec 5, 2023

turadg commented Dec 8, 2023

mhofman commented Dec 8, 2023

turadg commented Dec 8, 2023

erights commented Dec 8, 2023

mhofman commented Dec 9, 2023

mhofman commented Dec 9, 2023

github-actions bot commented Dec 10, 2023

turadg commented Dec 10, 2023

mhofman commented Dec 10, 2023

turadg commented Dec 11, 2023

mhofman commented Dec 11, 2023

github-actions bot commented Dec 13, 2023

mhofman left a comment

mhofman Jan 29, 2024

0xpatrickdev commented Jan 29, 2024

mhofman commented Jan 29, 2024

LuqiPan left a comment

erights commented Mar 13, 2024

drop Node 16 (EOL) #8365

drop Node 16 (EOL) #8365

Conversation

turadg commented Sep 21, 2023 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

mhofman Sep 21, 2023

Choose a reason for hiding this comment

mhofman Jan 29, 2024 • edited Loading

Choose a reason for hiding this comment

LuqiPan Jan 29, 2024

Choose a reason for hiding this comment

mhofman Jan 29, 2024

Choose a reason for hiding this comment

mhofman commented Sep 21, 2023

turadg commented Sep 21, 2023

erights commented Sep 22, 2023

mhofman left a comment

Choose a reason for hiding this comment

mhofman Dec 5, 2023

Choose a reason for hiding this comment

mhofman commented Dec 5, 2023

mhofman commented Dec 5, 2023 • edited Loading

turadg commented Dec 5, 2023

turadg commented Dec 8, 2023

mhofman commented Dec 8, 2023

turadg commented Dec 8, 2023

deployment-test (Loadgen)

getting-started (all)

erights commented Dec 8, 2023

mhofman commented Dec 9, 2023

mhofman commented Dec 9, 2023

github-actions bot commented Dec 10, 2023

turadg commented Dec 10, 2023

mhofman commented Dec 10, 2023

turadg commented Dec 11, 2023

mhofman commented Dec 11, 2023

github-actions bot commented Dec 13, 2023

mhofman left a comment

Choose a reason for hiding this comment

mhofman Jan 29, 2024

Choose a reason for hiding this comment

0xpatrickdev commented Jan 29, 2024

mhofman commented Jan 29, 2024

LuqiPan left a comment

Choose a reason for hiding this comment

erights commented Mar 13, 2024

turadg commented Sep 21, 2023 •

edited

Loading

mhofman Jan 29, 2024 •

edited

Loading

mhofman commented Dec 5, 2023 •

edited

Loading