Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Sync dependency versions with Agoric SDK. #55

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

kriskowal
Copy link
Member

I’ve applied these changes automatically using:

> ~/endo/scripts/all-versions.sh ~/agoric-sdk | ~/endo/scripts/set-versions.sh .

Towards avoiding certain incompatibilities discovered with a local agoric install.

@kriskowal kriskowal marked this pull request as ready for review November 9, 2023 01:12
@kriskowal
Copy link
Member Author

Integration with Agoric SDK here Agoric/agoric-sdk#8516

@kriskowal kriskowal requested a review from samsiegart November 9, 2023 01:27
Copy link

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of the sdk did you do agoric install with? I'm not sure about the intended use of this dapp, but I'm wondering whether it's intended to be used with the community-dev branch rather than HEAD. Maybe worth checking with devrel

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock Agoric/agoric-sdk#8365 (failing due to a lint plugin version)

not sure about the intended use of this dapp

I see it in https://docs.agoric.com/guides/dapps/dapp-templates.html . I expect it to continue to work by updating the devDeps. Not as certain about the cosmic-swingset one. I'd suggest omitting it but I'm willing to see what happens.

@kriskowal kriskowal merged commit d9b6fc7 into main Dec 8, 2023
1 check passed
@kriskowal kriskowal deleted the kriskowal-update-2023-11 branch December 8, 2023 19:24
@kriskowal
Copy link
Member Author

This synced to HEAD at the time of creation as that’s pinned in Agoric SDK CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants