feat(ses): tame Symbol so whitelist works #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-1577-symbol-repair
branch
from
31c66ea to
8da7e0b
Compare
kriskowal
reviewed
May 4, 2023
erights
force-pushed
the
markm-1577-symbol-repair
branch
from
93ce41e to
927848c
Compare
gibson042
reviewed
May 21, 2023
erights
force-pushed
the
markm-1577-symbol-repair
branch
from
927848c to
882f8d5
Compare
kriskowal
approved these changes
May 31, 2023
mhofman
pushed a commit
that referenced
this pull request
Jun 27, 2023
feat(ses): tame Symbol so whitelist works (cherry picked from commit 19180f6)
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1577
If the ses shim initializes on a platform in which Symbol contains non-configurable properties absent from the whitelist,
lockdownwill effectively succeed at deleting them anyway.This is a concern because later versions of the language, as well as bespoke variations, may add symbols whose meaning is currently unknown. The symbols themselves would be safe, be we should know what behavior they unlock before making them generally available.