Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop tests for Node 16 #8638

Merged
merged 3 commits into from
Mar 13, 2024
Merged

drop tests for Node 16 #8638

merged 3 commits into from
Mar 13, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Dec 8, 2023

refs: #8365

Description

Adopting Node 16 was blocked on some failures: #8365 (comment) . They seem to all be resolved now,

This removes Node 16 checks. It also documents how to handle Node LTS changes.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

Adds docs

Testing Considerations

CI suffices

Upgrade Considerations

Does not impact code

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Mar 13, 2024
@turadg turadg requested review from LuqiPan and 0xpatrickdev March 13, 2024 16:50
@turadg turadg changed the title integrate with Node 18 integrate with Node 18 and 20 Mar 13, 2024
@turadg turadg changed the title integrate with Node 18 and 20 drop tests for Node 16 Mar 13, 2024
Copy link
Contributor

@LuqiPan LuqiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## Updating

When a new version becomes Active LTS:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remark

Thank you for creating this checklist!

@mergify mergify bot merged commit 5b59e8a into master Mar 13, 2024
75 of 77 checks passed
@mergify mergify bot deleted the ta/integrate-18 branch March 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants