Skip to content

Commit

Permalink
ci: defer Node 18.19 compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
@turadg
turadg committed Dec 10, 2023
1 parent 054045c commit c8c4987
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 35 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/after-merge.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['16.x', '18.x']
node-version: ['16.x', '18.18']
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -38,7 +38,7 @@ jobs:
strategy:
matrix:
# note: only use one node-version
node-version: ['18.x']
node-version: ['18.18']
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/restore-node
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
strategy:
matrix:
# note: only use one node-version
node-version: ['18.x']
node-version: ['18.18']
if: ${{github.event_name == 'push' }}
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
strategy:
matrix:
# note: only use one node-version
node-version: ['18.x']
node-version: ['18.18']
if: ${{github.event_name == 'push'}}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ag-solo-xs.yml.DISABLED
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.18'
- name: cache node modules
uses: actions/cache@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/restore-node
with:
node-version: '18.x'
node-version: '18.18'

- name: yarn bench (boot)
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
# Prerequisites
- uses: ./.github/actions/restore-node
with:
node-version: 18.x
node-version: 18.18
keep-endo: 'true'

# Select a branch on dapp to test against by adding text to the body of the
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:
path: ./agoric-sdk
- uses: ./agoric-sdk/.github/actions/restore-node
with:
node-version: 18.x
node-version: 18.18
path: ./agoric-sdk
# Forces xsnap to initialize all memory to random data, which increases
# the chances the content of snapshots may deviate between validators
Expand Down
54 changes: 27 additions & 27 deletions .github/workflows/test-all-packages.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['16.x', '18.x']
node-version: ['16.x', '18.18']
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/restore-node
with:
node-version: '18.x'
node-version: '18.18'

# first job also does repo-level linting
- name: lint repo format
Expand All @@ -84,7 +84,7 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/restore-node
with:
node-version: '18.x'
node-version: '18.18'

- name: yarn lint rest
run: ./scripts/lint-with-types.sh rest
Expand All @@ -98,12 +98,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
Expand Down Expand Up @@ -189,12 +189,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
- uses: actions/checkout@v3
Expand Down Expand Up @@ -306,12 +306,12 @@ jobs:
strategy:
matrix:
# test:xs is noop in solo/package.json
engine: ['16.x', '18.x']
engine: ['16.x', '18.18']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
Expand Down Expand Up @@ -347,12 +347,12 @@ jobs:
strategy:
matrix:
# test:xs is noop in cosmic-swingset/package.json
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
Expand Down Expand Up @@ -391,12 +391,12 @@ jobs:
strategy:
matrix:
# test:xs is noop in inter-protocol/package.json
engine: ['16.x', '18.x']
engine: ['16.x', '18.18']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
Expand Down Expand Up @@ -431,12 +431,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
Expand Down Expand Up @@ -472,12 +472,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
Expand Down Expand Up @@ -514,12 +514,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
Expand Down Expand Up @@ -566,12 +566,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
- uses: actions/checkout@v3
Expand Down Expand Up @@ -607,12 +607,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs' || 'test' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
- uses: actions/checkout@v3
Expand Down Expand Up @@ -649,13 +649,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
# END-TEST-BOILERPLATE
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs-unit' || 'test:unit' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
# BEGIN-TEST-BOILERPLATE
Expand Down Expand Up @@ -691,13 +691,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
engine: ['16.x', '18.x', 'xs']
engine: ['16.x', '18.18', 'xs']
steps:
- name: set vars
id: vars
# END-TEST-BOILERPLATE
run: |
echo "node-version=${{ matrix.engine == 'xs' && '18.x' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "node-version=${{ matrix.engine == 'xs' && '18.18' || matrix.engine }}" >> $GITHUB_OUTPUT
echo "test=${{ matrix.engine == 'xs' && 'test:xs-worker' || 'test:swingset' }}" >> $GITHUB_OUTPUT
echo "GH_ENGINE=${{ matrix.engine }}" >> $GITHUB_ENV
# BEGIN-TEST-BOILERPLATE
Expand Down

0 comments on commit c8c4987

Please sign in to comment.