This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
Feature: Import/Export Wallet #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add JS implementation of Indy methods
Add implementation of iOS Indy methods
Ignoring it globally causes android src to be excluded from the packed tarball Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
npmignore: ignore src only in project root
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
* Store pool and wallet handles in maps Makes the API compatible with libindy nodejs wrapper * Update exported methods to use walletHandle and buffers iOS native calls remain untested * android: Update module name * crypto: fix return types Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
Add non_secrets API
Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
Bump indy version
Rename IndyBridge to IndySdk (AbsaOSS#10)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Added implementation of buildGetAttribRequest, buildGetNymRequest and parseGetNymResponse Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…aOSS#33) * Create Schema methods * Create Credential Definition * Issue credential * Added missing Platform Check * Issuer Create Credential Signed-off-by: Arhaam Patvi <thearhaam@gmail.com>
* remove framework search paths, update docs * docs: remove "Recommended" from ios install step Signed-off-by: Timo Glastra <timo@animo.id>
…SS#42) Signed-off-by: blu3beri <berend@animo.id>
* fix: fixed hot reload on React Native. Now it retains wallet and pool handle * fix: added back credentialSearch variables
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.19...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.5 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.5...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.21 to 0.7.28. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Commits](faisalman/ua-parser-js@0.7.21...0.7.28) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
…aOSS#56) Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: Timo Glastra <timo@animo.id>
Added import export wallet support. Added Android support and using existing IOS support
jakubkoci
suggested changes
Jun 29, 2021
There was a problem hiding this comment.
Hi, @TimovanDijk. Thanks for your contribution. Could you just add the condition as I described. It will be easier to recognize what is not implemented on the iOS platform. Thanks.
| @@ -291,6 +291,14 @@ const indy = { | |||
| return IndySdk.deleteWallet(JSON.stringify(config), JSON.stringify(credentials)) | |||
| }, | |||
|
|
|||
| exportWallet(wh: WalletHandle, exportConfig: Object): Promise<void> { | |||
| return IndySdk.exportWallet(wh, JSON.stringify(exportConfig)) | |||
There was a problem hiding this comment.
Could you please throw an Error for the iOS platform? The same for the second method.
Suggested change
| return IndySdk.exportWallet(wh, JSON.stringify(exportConfig)) | |
| if (Platform.OS === 'ios') { | |
| throw new Error(`Unsupported operation! Platform: ${Platform.OS}`) | |
| } | |
| return IndySdk.exportWallet(wh, JSON.stringify(exportConfig)) |
There was a problem hiding this comment.
@jakubkoci It is already implemented for iOS.
@TimovanDijk can't test on iOS, so I'll test it on iOS and report back
|
I still need to look at it! Can you reopen? |
|
Oh no. I'm sorry. I did a force push with sign-off for each of my commits to merge it to the new Hyperledger repo 🤦♂️ I cannot reopen the PR. We should perhaps do a new PR there when I commit the changes from this repo to the Hyperledger one. I have everything prepared, waiting for an official approval now. Hopefully, the changes should be available here bb75a2b |
|
I'll reopen when the transfer is complete |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added import export wallet support. Added Android support and using existing IOS support