This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
fix: matched searchCredsForProofReq method types to node wrapper #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IndySDK Node wrapper extraQuery type in the method
proverSearchCredentialsForProofReq
differs from the Android and iOS types. Node allows for the parameter to be either a JSON object or null, while Java requires it to be not-null:Since the tests in AFJ use the Node wrapper they didn't uncover this issue until I tried to use it from a React Native perspective. I opted to adjust the method here to align with the Node types. I'd be happy to take a different approach if desired though.