This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
Android: Use walletHandle and poolHandle #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the API compatible with libindy nodejs wrapper Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
iOS native calls remain untested
Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
|
Thanks @gnarula 👍 Good idea with this: It allows us to keep information about what's implemented without too much investigation all over again. |
jakubkoci
pushed a commit
that referenced
this pull request
Jul 14, 2021
* Store pool and wallet handles in maps Makes the API compatible with libindy nodejs wrapper * Update exported methods to use walletHandle and buffers iOS native calls remain untested * android: Update module name * crypto: fix return types Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the android module to use walletHandle and poolHandles.
This closes #2
Also added
packMessage(),unpackMessage(),cryptoSign()andcryptoVerify()