This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
Feat: add verifier verify proof in Android #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
jakubkoci
reviewed
Apr 15, 2021
src/index.js
Outdated
| proof: Indy.IndyProof, | ||
| schemas: Schemas, | ||
| credentialDefs: CredentialDefs, | ||
| revRegsDefs: Indy.RevRegsDefs, |
There was a problem hiding this comment.
Hi @JamesKEbert, thanks for this update. I'm just curious, where do you get the Indy.* types from? I don't see any Indy import or definition in this file 🤔
There was a problem hiding this comment.
Ahh whoops. Those types came as a result from referencing code from a previous implementation I had done. I thought I got everything sorted but I missed that somehow. Thanks for catching that--I just pushed a commit revising the types.
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
jakubkoci
approved these changes
Apr 18, 2021
jakubkoci
pushed a commit
that referenced
this pull request
Jul 14, 2021
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the verifier verify proof method functionality in Android.