Deploy RC 440 to Production #11675
Merged
Deploy RC 440 to Production #11675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#11653) * Add a test controller for IPP enrollments Add a new route, /test/ipp (not enabled in prod!) Features: - Lists the 10 most recent enrollments + their statuses - Puts a big "Approve" button on pending ones to simulate USPS approval [skip changelog] * Left-align heading cells
* Remove fast-glob direct dependency changelog: Internal, Dependencies, Drop dependencies in favor of Node.js native utilities * Update clipboard-polyfill Now includes fixed TypeScript types. Previously wasn't possible to upgrade because project is ESM, but Node.js 22 adds experimental support for CommonJS require of ESM * Upgrade TypeScript to latest version Avoid issues with types on Array.fromAsync * Sync yarn.lock * Reduce test flakiness with path matcher --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
[skip changelog]
* make input required * changelog: Bug Fixes, Partner agency, prevent blank submission of preferred email form * add changes to spec feature * rename variable * include backend validation for the blank field * change course on handling select email view, update specs accordingly, add spec that covers a validated email id presence * un-flip-flop expected error details, update edit spec * clean up unneeded spec item, add test to account connected app spec * fix tests by compensating for hidden absolute positioned elements * revise spec after merge * undo mis-merged value * preselect email radio button * improve test coverage to include selecting the correct email id * added assertion to expected value checked when SP has email assigned
…ports single email (#11656)
* delete prod default available_locale * changelog: Internal, Enable Chinese in staging, Delete production available_locales to use default which includes zh
Minor style / lint fixes. changelog: Internal,Socure,Cleanup of error handling
* Use Promise.withResolvers to simplify promise handling changelog: Internal, Code Quality, Simplify code using newly-available JavaScript features * Pass dummy error object to rejected promise
* Add rubocop-capybara to require reliable path matching changelog: Internal, Testing, Add rubocop-capybara * correct path matching
* LG-10206 Move STEP_INDICATOR_STEP constants out of InPersonFlow changelog: Internal, In-person proofing, Move STEP_INDICATOR_STEP constants out of InPersonFlow
- Change to idv_please_call to indicate it is used by idv generally - Keep in_person_please_call as an alias on the theory that we need it for 1 deploy [skip changelog]
…11642) * Add example code demonstrating lint failure * Dump stderr on Rubocop error result * Add failing test case changelog: Internal, Static Analysis, Fix custom linter for configurable mail delivery * Verify send type before checking method name Fail if can't check type * Disable linter for intentional spec example
…th page. (#11661) * set immediaelyBeginCapture to false in context * add changelog changelog: Bug Fixes, Doc Auth, Fix try again button opening up Selfie SDK * remove immediatelyBeginCapture from selfie context * Revert "remove immediatelyBeginCapture from selfie context" This reverts commit 28a9b1b.
… limit count appears correctly (#11671)
[skip changelog]
**Why** * When Idv::AnalyticsEventEnhancer was first introduced it was opt-in, but this no longer makes sense for our current analytics tracking needs. * While a better long-term strategy would be to eliminate the event enhancer, this should be addressed in future work given its complexity. **How** * Broke up the IGNORED_METHODS constant into 3 buckets: 1) frontend events and 2) events solely used in jobs. Anything that doesn't fall neatly in either category should just be put in the `IGNORED_METHODS` constant and those additions should be minimal. * Added specs to ensure that the list of event methods referenced don't get out of sync with AnalyticsEvents and that there is no overlap between ignored and explicitly opted-in methods. * Added TODO comments for missing events in the feature spec. **Non-Goals** * Adding new tests to validate event coverage in spec/features/idv/analytics_spec.rb * Eliminating the event enhancer metaprogramming approach * Eliminating unused events changelog: Internal, IdV Analytics, Make IdV event enhancement opt-out
* Delete deprecated FSM StateID url * changelog: Internal, In-person proofing, Delete deprecated FSM state ID url
* resolve merge conflicts * repeat webhook before processing it * test repeating webhooks * clean up unused lines * refactor specs to check NewRelic args * add webhook repeater test for generic webhook changelog: Internal, Document Authentication, Repeat webhooks for docv * add feature specs for repeated webhooks * check that webhooks is attempting to repeat * fix typo in spec * add expectation for sending all webhooks unit spec * update spec loops * remove stub of :find_by * move repeat webhooks to a job * repeat jobs later * resolve merge conflict * update spec to use jobs * repeater timeout decrease to 15s * minor refactors
matthinz
requested review from
a team,
mdiarra3,
jmax-gsa,
gina-yamada,
kevinsmaster5,
theabrad,
jennyverdeyen and
AShukla-GSA
aduth
approved these changes
Dec 19, 2024
kevinsmaster5
approved these changes
Dec 19, 2024
We missed this when we got rid of the ProofingComponent model in #11564 [skip changelog]
* Rework mailer_helper and add spec - Slightly improve error output - Capture behavior in a dedicated spec [skip changelog] * Add expect_email_not_delivered helper Assert that a certain email was not sent. * Update alert_user_about_account_verified_spec These specs weren't actually testing the thing we thought they were, since the text_part of the email did not contain HTML.
changelog: User-Facing Improvements, Accessibility, skipnav container no longer blocks content at large zoom levels
n1zyy
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features