Use Promise.withResolvers to simplify promise handling #11666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
approved these changes
Dec 18, 2024
changelog: Internal, Code Quality, Simplify code using newly-available JavaScript features
aduth
force-pushed
the
aduth-promise-with-resolvers
branch
from
4729989 to
1b7a4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates a few instances of JavaScript behavior now able to be simplified using
Promise.withResolvers, available as of Node.js v22.See MDN "Description" documentation for an explanation of the exact type of code this feature seeks to replace.
This builds upon #11605 and #11648, leveraging newly-available features.
📜 Testing Plan
Since the changes only affect specs, it should be sufficient to verify that tests pass: