Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lg-15193 verify socure rate limit display decrements correctly #11671

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

AShukla-GSA
Copy link
Member

Verify socure rate limit display decrements correctly

🎫 Ticket

Link to the relevant ticket:
LG-15193

🛠 Summary of changes

Adding feature test to ensure that rate limit value displayed to user on Socure error page is correct and properly decrements as user fails more than once.
Bug was fixed as a part of LG-14010

Copy link
Contributor

@jmax-gsa jmax-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AShukla-GSA AShukla-GSA force-pushed the lg-15193-socure-attempt-count-bug-fix branch from b274cca to d5dbf15 Compare December 18, 2024 20:17
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Abir - LGTM!

@AShukla-GSA AShukla-GSA merged commit 67e33f2 into main Dec 18, 2024
2 checks passed
@AShukla-GSA AShukla-GSA deleted the lg-15193-socure-attempt-count-bug-fix branch December 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants