Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14010 minor review comments #11595

Merged
merged 3 commits into from
Dec 18, 2024
Merged

LG-14010 minor review comments #11595

merged 3 commits into from
Dec 18, 2024

Conversation

jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Dec 4, 2024

🎫 Ticket

Link to the relevant ticket:
LG-14010

🛠 Summary of changes

General cleanup and minor syntax improvements from the previous PR.

@jmax-gsa jmax-gsa requested a review from amirbey December 4, 2024 20:07
changelog: Internal,Socure,Cleanup of error handling
@jmax-gsa jmax-gsa force-pushed the jmax/LG-14010-assorted-cleanup branch from 04e5950 to afaafdd Compare December 5, 2024 15:15
Copy link
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿 ... any updates on SocureConcern#errors ?

@amirbey amirbey self-requested a review December 17, 2024 16:50
@jmax-gsa jmax-gsa merged commit 870e1d8 into main Dec 18, 2024
2 checks passed
@jmax-gsa jmax-gsa deleted the jmax/LG-14010-assorted-cleanup branch December 18, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants