Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Handlebars to v1.3.0 #1908

Closed
wants to merge 2 commits into from

Conversation

aljimenez
Copy link
Contributor

@yahoocla
Copy link

CLA is valid!

@aljimenez aljimenez changed the title Handlebars v1.3.0 Upgrade Handlebars to v1.3.0 Jul 17, 2014
@okuryu
Copy link
Member

okuryu commented Jul 19, 2014

Cool, That's something that I've always wanted to do. BTW, it should push into dev-3.x instead of dev-master?

@aljimenez
Copy link
Contributor Author

I am not sure which branch it should be merged into but the previous handlebar upgrades merged into dev-master. Let me know if there are any questions about the pull request; the solution was a little tricky since handlebars' code has been refactored to ES6 modules which get transpiled to nodejs modules that include 'require' statements. The modified grunt file takes this into consideration and removes require statements and wraps each module in an anonymous function. This should work with future releases of handlebars, with little or no changes to the grunt file.

@okuryu
Copy link
Member

okuryu commented Jul 20, 2014

the solution was a little tricky since handlebars' code has been refactored to ES6 modules which get transpiled to nodejs modules that include 'require' statements.

Yeah, I've tried to do this before too, but I ran into this problem, and I was wondering what the best way is.

At present, the original Handlebars hasn't built YUI format module.
https://github.com/wycats/handlebars.js/blob/a601b24a7320d2348f6b34693c4918dc08875737/Gruntfile.js#L44-76

So I think we should contiribute to transpiling to YUI format module first on handlebars repository, and then work on YUI core module repository, but before that we have to update es6-module-transpiler, which es6-module-packager is dependent on, to the latest version.
https://github.com/kpdecker/es6-module-packager/issues/5

Or, I think we may be able to transpile from the original Handlebars to YUI module by using es6-module-transpiler after importing Handlebars source code.

Because there are a few issues in order to solve everything, if the tests are passed, I personally think this approach is fine.

@okuryu
Copy link
Member

okuryu commented Jul 28, 2014

I hope some feedback on this from Reviewers.

@ericf @caridy @rgrove @lsmith

@okuryu
Copy link
Member

okuryu commented Sep 29, 2014

#1961 has been merged. It will be more latest Handlebars version.

@okuryu okuryu closed this Sep 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants