-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Handlebars to v1.3.0 #1908
Conversation
CLA is valid! |
Cool, That's something that I've always wanted to do. BTW, it should push into |
I am not sure which branch it should be merged into but the previous handlebar upgrades merged into dev-master. Let me know if there are any questions about the pull request; the solution was a little tricky since handlebars' code has been refactored to ES6 modules which get transpiled to nodejs modules that include 'require' statements. The modified grunt file takes this into consideration and removes require statements and wraps each module in an anonymous function. This should work with future releases of handlebars, with little or no changes to the grunt file. |
Yeah, I've tried to do this before too, but I ran into this problem, and I was wondering what the best way is. At present, the original Handlebars hasn't built YUI format module. So I think we should contiribute to transpiling to YUI format module first on handlebars repository, and then work on YUI core module repository, but before that we have to update Or, I think we may be able to transpile from the original Handlebars to YUI module by using Because there are a few issues in order to solve everything, if the tests are passed, I personally think this approach is fine. |
#1961 has been merged. It will be more latest Handlebars version. |
All tests pass.