-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update YUI Handlebars to use v2.0.0 #1961
Conversation
modified: Gruntfile.js modified: build.json
modified: js/handlebars-base.js modified: js/handlebars-compiler-ast.js modified: js/handlebars-compiler-base.js modified: js/handlebars-compiler-compiler.js new file: js/handlebars-compiler-helpers.js modified: js/handlebars-compiler-javascript-compiler.js modified: js/handlebars-compiler-parser.js modified: js/handlebars-runtime.js modified: js/handlebars-utils.js modified: js/handlebars.js modified: js/handlebars.runtime.js
…e string `false` instead of an empty string for the value of false.
…ime. modified: Gruntfile.js
…mport a Helpers reference. modified: js/handlebars-compiler-parser.js
CLA is valid! |
I don't have too much to say about this, if it works, and tests are passing, I'm good with it. Ideally, we can get @aljimenez to try it in search manually, and see if that works. |
Yeah, I feel the same as Caridy. It looks like all the tests are passing, so 👍 |
@caridy I'll give it a try in our Search apps. Thank you all, we look forward to using the latest handlebars features. |
I updated the |
I've tested these changes on our Search application with Mojito and everything works as expected so far. |
\o/ |
This pull request adds some updates to #1908 for including handlebars v2.0.0.
This is pull request is dependent on yui/handlebars.js#2 as the updated handlebars code causes an error in the YUI Template test suite.