Update YUI Handlebars to use v2.0.0 #1956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… v2.0.0. modified: js/handlebars-base.js modified: js/handlebars-compiler-ast.js modified: js/handlebars-compiler-base.js modified: js/handlebars-compiler-compiler.js new file: js/handlebars-compiler-helpers.js new file: js/handlebars-compiler-javascript-compiler.js modified: js/handlebars-compiler-parser.js new file: js/handlebars-exception.js modified: js/handlebars-runtime.js new file: js/handlebars-safe-string.js modified: js/handlebars-utils.js new file: js/handlebars.js new file: js/handlebars.runtime.js
…e string `false` instead of an empty string for the value of false.
|
CLA is valid! |
|
I pitty for the neglected #1908, but this PR might be better. It's more latest version. |
|
@okuryu |
|
Closed because there is a regression in this pr. I'll open a new one once that's sorted. The new pr will also include the commits from #1908. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes unit tests for:
Its also been tested manually in ie 6, 7, 8 with basic examples.
A unit test had to be updated to reflect that a value of
falsereturn "false" instead of "". (handlebars-lang/handlebars.js#827)I didn't see anyting in the release notes for v2.0.0 that should cause any issues but it wouldn't hurt for someone to look over them as well.
https://github.com/wycats/handlebars.js/blob/master/release-notes.md