Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics tab on table page is broken #5582

Closed
robertsami opened this issue Sep 3, 2020 · 3 comments
Closed

Metrics tab on table page is broken #5582

robertsami opened this issue Sep 3, 2020 · 3 comments
Assignees
@sshev
Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX platform/current
Milestone
v2.3

Comments

@robertsami
Copy link
Contributor

http://portal.dev.yugabyte.com/universes/4ea18f4b-3b1c-46ea-b291-aca81eba88a1/tables/000030a9-0000-3000-8000-000000004019?tab=metrics

Failed to load resource: the server responded with a status of 505 (HTTP Version Not Supported)
/api/v1/insecure_login:1 Failed to load resource: the server responded with a status of 401 (Unauthorized)
2VM49 react_devtools_backend.js:2273 TypeError: Cannot read property 'title' of undefined
    at a.value (GraphPanel.js:229)
    at Ba (2.b87f9cd0.chunk.js:sourcemap:1)
    at Pa (2.b87f9cd0.chunk.js:sourcemap:1)
    at gs (2.b87f9cd0.chunk.js:sourcemap:1)
    at cl (2.b87f9cd0.chunk.js:sourcemap:1)
    at sl (2.b87f9cd0.chunk.js:sourcemap:1)
    at Js (2.b87f9cd0.chunk.js:sourcemap:1)
    at 2.b87f9cd0.chunk.js:sourcemap:1
    at t.unstable_runWithPriority (2.b87f9cd0.chunk.js:sourcemap:1)
    at $i (2.b87f9cd0.chunk.js:sourcemap:1)
overrideMethod @ VM49 react_devtools_backend.js:2273
2.b87f9cd0.chunk.js:sourcemap:1 Uncaught TypeError: Cannot read property 'title' of undefined
    at a.value (GraphPanel.js:229)
    at Ba (2.b87f9cd0.chunk.js:sourcemap:1)
    at Pa (2.b87f9cd0.chunk.js:sourcemap:1)
    at gs (2.b87f9cd0.chunk.js:sourcemap:1)
    at cl (2.b87f9cd0.chunk.js:sourcemap:1)
    at sl (2.b87f9cd0.chunk.js:sourcemap:1)
    at Js (2.b87f9cd0.chunk.js:sourcemap:1)
    at 2.b87f9cd0.chunk.js:sourcemap:1
    at t.unstable_runWithPriority (2.b87f9cd0.chunk.js:sourcemap:1)
    at $i (2.b87f9cd0.chunk.js:sourcemap:1)
ui_theme:1 Failed to load resource: the server responded with a status of 505 (HTTP Version Not Supported)
@robertsami robertsami added area/ui All issues relating to UI/UX area/platform Yugabyte Platform labels Sep 3, 2020
@streddy-yb streddy-yb added this to the v2.3 milestone Sep 15, 2020
@streddy-yb streddy-yb mentioned this issue Sep 15, 2020
Closed
@iSignal
Copy link
Contributor

iSignal commented Sep 16, 2020

Also, not exactly related to the metrics tab - but another UI issue on the tables section -

The alignment of values on the main tables list is broken. On wide screens, the values do not follow the headers.
Screen Shot 2020-09-15 at 7 01 51 PM

sshev added a commit that referenced this issue Sep 18, 2020
@sshev
[YW][#5582] Fix Metrics tab on table page
5b4841e 
Summary:
Part of the configuration of the metric graphs was removed in D9051 (supposedly accidentally) which caused the issue of a broken metrics tab at the table page.
{F14049}

Address issue with columns misalignment
{F14051}

Test Plan:
1. Run UI
2. Open any universe, click Tables tab --> see aligned columns in tables list
3. Click on any table in the list, open on Metrics tab --> see the metric graphs page

Reviewers: andrew

Reviewed By: andrew

Subscribers: rsami, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D9413
@sshev
Copy link
Collaborator

sshev commented Sep 18, 2020

Part of the configuration of the metric graphs was unintentionally removed at efc3d41#diff-2c3a1d35efea16b272279b22281a36f9L117-L145 which caused page malfunctioning

sshev added a commit that referenced this issue Sep 18, 2020
@sshev
Backport to 2.1: [YW][#5582] Fix Metrics tab on table page
35c0201 
Summary:
Part of the configuration of the metric graphs was removed in D9051 (supposedly accidentally) which caused the issue of a broken metrics tab at the table page.
{F14049}

Address issue with columns misalignment
{F14051}

Test Plan:
1. Run UI
2. Open any universe, click Tables tab --> see aligned columns in tables list
3. Click on any table in the list, open on Metrics tab --> see the metric graphs page

Reviewers: andrew

Reviewed By: andrew

Subscribers: rsami, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D9413

(cherry picked from commit 5b4841e)
sshev added a commit that referenced this issue Sep 18, 2020
@sshev
Backport to 2.2: [YW][#5582] Fix Metrics tab on table page
5683425 
Summary:
Part of the configuration of the metric graphs was removed in D9051 (supposedly accidentally) which caused the issue of a broken metrics tab at the table page.
{F14049}

Address issue with columns misalignment
{F14051}

Test Plan:
1. Run UI
2. Open any universe, click Tables tab --> see aligned columns in tables list
3. Click on any table in the list, open on Metrics tab --> see the metric graphs page

Reviewers: andrew

Reviewed By: andrew

Subscribers: rsami, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D9413

(cherry picked from commit 5b4841e)
@sshev
Copy link
Collaborator

sshev commented Sep 18, 2020

Fixed in master and backported to 2.1 and 2.2 branches

@sshev sshev closed this as completed Sep 18, 2020
@sshev sshev mentioned this issue Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sshev sshev

Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX platform/current
Projects
None yet
Milestone
v2.3
Development

No branches or pull requests
6 participants
@robertsami @iSignal @sshev @andrewc-dev @streddy-yb @SergeyPotachev