Skip to content

Commit

Permalink
Backport to 2.1: [YW][#5582] Fix Metrics tab on table page
Browse files Browse the repository at this point in the history
Summary:
Part of the configuration of the metric graphs was removed in D9051 (supposedly accidentally) which caused the issue of a broken metrics tab at the table page.
{F14049}

Address issue with columns misalignment
{F14051}

Test Plan:
1. Run UI
2. Open any universe, click Tables tab --> see aligned columns in tables list
3. Click on any table in the list, open on Metrics tab --> see the metric graphs page

Reviewers: andrew

Reviewed By: andrew

Subscribers: rsami, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D9413

(cherry picked from commit 5b4841e)
  • Loading branch information
sshev committed Sep 18, 2020
1 parent f7b6de1 commit 35c0201
Showing 1 changed file with 31 additions and 1 deletion.
32 changes: 31 additions & 1 deletion managed/ui/src/components/metrics/GraphPanel/GraphPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,37 @@ const panelTypes = {
"response_sizes",
"cql_yb_transaction",
"cql_yb_rpc_connections"
]}
]},

tserver_table: {
title: "Tablet Server",
metrics: ["tserver_log_latency",
"tserver_log_bytes_written",
"tserver_log_bytes_read",
"tserver_log_ops_second",
"tserver_log_stats",
"tserver_cache_reader_num_ops",
"tserver_glog_info_messages"]
},

lsmdb_table: {
title: "DocDB",
metrics: ["lsm_rocksdb_num_seek_or_next",
"lsm_rocksdb_num_seeks_per_node",
"lsm_rocksdb_total_sst_per_node",
"lsm_rocksdb_avg_num_sst_per_node",
"lsm_rocksdb_latencies_get",
"lsm_rocksdb_latencies_write",
"lsm_rocksdb_latencies_seek",
"lsm_rocksdb_block_cache_hit_miss",
"lsm_rocksdb_blooms_checked_and_useful",
"lsm_rocksdb_stalls",
"lsm_rocksdb_flush_size",
"lsm_rocksdb_compaction",
"lsm_rocksdb_compaction_time",
"lsm_rocksdb_compaction_numfiles",
"docdb_transaction"]
}
};

class GraphPanel extends Component {
Expand Down

0 comments on commit 35c0201

Please sign in to comment.