Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomerMetricsPanel in TableDetail may be broken #5361

Closed
robertsami opened this issue Aug 11, 2020 · 2 comments
Closed

CustomerMetricsPanel in TableDetail may be broken #5361

robertsami opened this issue Aug 11, 2020 · 2 comments
Assignees
Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX

Comments

@robertsami
Copy link
Contributor

at /universes/{universe-id}/tables/{table-id}

clicking on the "metrics" tab gives:

react-dom.development.js:11143 Uncaught TypeError: Cannot read property 'title' of undefined
    at GraphPanel.render (GraphPanel.js:230)
    at finishClassComponent (react-dom.development.js:17097)
    at updateClassComponent (react-dom.development.js:17050)
    at beginWork (react-dom.development.js:18510)
    at HTMLUnknownElement.callCallback (react-dom.development.js:189)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:238)
    at invokeGuardedCallback (react-dom.development.js:291)
    at beginWork$1 (react-dom.development.js:23052)
    at performUnitOfWork (react-dom.development.js:22016)
    at workLoopSync (react-dom.development.js:21992)
    at performSyncWorkOnRoot (react-dom.development.js:21610)
    at react-dom.development.js:11130
    at unstable_runWithPriority (scheduler.development.js:656)
    at runWithPriority$1 (react-dom.development.js:11076)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11125)
    at flushSyncCallbackQueue (react-dom.development.js:11113)
    at scheduleUpdateOnFiber (react-dom.development.js:21053)
    at Object.enqueueSetState (react-dom.development.js:12675)
    at Transition.push../node_modules/react/cjs/react.development.js.Component.setState (react.development.js:464)
    at Transition.safeSetState (Transition.js:388)
    at Transition.js:367
    at nextCallback (Transition.js:400)

It looks like maybe the issue is that graphPanelTypes in CustomerMetricsPanel specifies tserver_table data type but panelTypes in GraphPanel has no such corresponding key

@robertsami robertsami added area/platform Yugabyte Platform area/ui All issues relating to UI/UX labels Aug 11, 2020
@bmatican bmatican assigned Arnav15 and unassigned andrewc-dev Sep 21, 2020
@bmatican
Copy link
Contributor

Was talking to @SergeyPotachev turns out this traces back to https://phabricator.dev.yugabyte.com/D9051

@Arnav15 any reason why you removed the per-table metric keys in that diff?

@sshev
Copy link
Collaborator

sshev commented Sep 21, 2020

This one seems to be a duplicate of #5582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX
Projects
None yet
Development

No branches or pull requests

6 participants