Add toJS to return TreeNode of Tree #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 88.63% 88.55% -0.08%
==========================================
Files 80 80
Lines 8892 8896 +4
Branches 816 817 +1
==========================================
- Hits 7881 7878 -3
- Misses 704 711 +7
Partials 307 307
☔ View full report in Codecov by Sentry. |
hackerwins
approved these changes
Sep 2, 2023
humdrum
reviewed
Sep 4, 2023
humdrum
reviewed
Sep 4, 2023
humdrum
reviewed
Sep 4, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Add toJS to return TreeNode of Tree.
Previously, we return stringified TreeNode (toJSON) so that users have to parse it when they want to use. Also, toJSON was created for testing purposes.
So I just made new
toJSto return TreeNode type tree data.Any background context you want to provide?
In the issue, I mentioned that i'm gonna restore
iterator. At first I thought it was necessary, but now I don't think so because the result of postorder traversal is not necessary.What are the relevant tickets?
Address yorkie-team/yorkie#632
Checklist