Add rootTreeNode for JsonTree #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7hong13
added
bug 🐞
skhugh
reviewed
Oct 12, 2023
Comment on lines
430
to
443
| public sealed interface Others : PresenceChange { | ||
| public sealed class Others(public open val changed: PresenceInfo) : PresenceChange { | ||
|
|
||
| /** | ||
| * Means that the client has established a connection with the server, | ||
| * enabling real-time synchronization. | ||
| */ | ||
| public data class Watched(public val watched: PresenceInfo) : Others | ||
| public data class Watched(override val changed: PresenceInfo) : Others(changed) | ||
|
|
||
| /** | ||
| * Means that the client has been disconnected. | ||
| */ | ||
| public data class Unwatched(public val unwatched: PresenceInfo) : Others | ||
| public data class Unwatched(override val changed: PresenceInfo) : Others(changed) | ||
|
|
||
| /** | ||
| * Means that the presences of the client has been updated. | ||
| */ | ||
| public data class PresenceChanged(public val changed: PresenceInfo) : Others | ||
| public data class PresenceChanged(override val changed: PresenceInfo) : | ||
| Others(changed) | ||
| } |
There was a problem hiding this comment.
I think this would be more compact.
public sealed interface Others : PresenceChange {
public val changed: PresenceInfo
/**
* Means that the client has established a connection with the server,
* enabling real-time synchronization.
*/
public data class Watched(override val changed: PresenceInfo) : Others
/**
* Means that the client has been disconnected.
*/
public data class Unwatched(override val changed: PresenceInfo) : Others
/**
* Means that the presences of the client has been updated.
*/
public data class PresenceChanged(override val changed: PresenceInfo) : Others
}
There was a problem hiding this comment.
I changed Others back to interface in 9ae165c.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 83.05% 78.24% -4.82%
==========================================
Files 63 63
Lines 3654 3672 +18
Branches 534 572 +38
==========================================
- Hits 3035 2873 -162
- Misses 325 502 +177
- Partials 294 297 +3
☔ View full report in Codecov by Sentry. |
skhugh
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
rootTreeNodeforJsonTreeand make onlyJsonTree.TreeNodepublicly visibleSelectOpInfoOperations (I think I missed some changes in the JS SDK.)PresenceChange.OthersAny background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist