Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toJS to return TreeNode of Tree #115

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add toJS to return TreeNode of Tree #115

merged 2 commits into from
Sep 25, 2023

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Sep 20, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum added this to the 0.4.7 milestone Sep 20, 2023
@humdrum humdrum self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01% ⚠️

Comparison is base (c73041b) 44.24% compared to head (fd284cd) 44.24%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   44.24%   44.24%   -0.01%     
==========================================
  Files         105      105              
  Lines       22229    22239      +10     
==========================================
+ Hits         9836     9839       +3     
- Misses      12393    12400       +7     
Files Changed Coverage Δ
Sources/Document/Json/JSONTree.swift 17.77% <0.00%> (-0.36%) ⬇️
Sources/Document/CRDT/CRDTTree.swift 66.40% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants