Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into v1 #39

Merged
merged 5 commits into from
May 1, 2024
Merged

Merge main into v1 #39

merged 5 commits into from
May 1, 2024

Conversation

jesuyedavid
Copy link
Contributor

@jesuyedavid jesuyedavid commented Apr 30, 2024

  • Remove Node 16 deprecation warnings (#37, #38)

EmilyZhang777 and others added 5 commits April 12, 2024 11:10
Update `main.yml`, `percy_snapshots.yml`, `run-linting.yml`, `run_tests.yml`, `sync_default_branch.yml`, `sync_develop_and_main.yml`, `third_party_notices_check.yml`, `.update_docs.yml`, `version_update.yml`, and `wcag_test.yml` to remove Node 16 deprecation warnings.

J=WAT-3814
TEST=manual

For `main.yml`, test the check on this PR, for `percy_snapshots.yml`, test in `answers-search-ui`, and for the other workflows, test in a fork of `search-ui-react` and see that the workflows no longer produce warnings.
Updated coverage workflow to satisfy node20 requirements
Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the PR title and description to follow other similar PRs like this one? the description typically acts as release notes for the v1 branch, because all the details are already in the linked PRs and no additional work is done in this PR

@jesuyedavid jesuyedavid changed the title Update to Remove node16 Deprecation Warnings in Various Workflows Merge main into v1 May 1, 2024
@jesuyedavid jesuyedavid merged commit 1c38f5d into v1 May 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants