Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 16 deprecation warnings from most workflows #38

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Apr 15, 2024

Update main.yml, percy_snapshots.yml, run-linting.yml, run_tests.yml, sync_default_branch.yml, sync_develop_and_main.yml, third_party_notices_check.yml, .update_docs.yml, version_update.yml, and wcag_test.yml to remove Node 16 deprecation warnings.

J=WAT-3814
TEST=manual

For main.yml, test the check on this PR, for percy_snapshots.yml, test in answers-search-ui, and for the other workflows, test in a fork of search-ui-react and see that the workflows no longer produce warnings.

@nmanu1 nmanu1 requested a review from a team as a code owner April 15, 2024 19:22
Copy link
Contributor

@jesuyedavid jesuyedavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nmanu1 nmanu1 merged commit c4dd373 into main Apr 15, 2024
2 checks passed
@nmanu1 nmanu1 deleted the dev/use-node-20 branch April 15, 2024 20:45
@jesuyedavid jesuyedavid mentioned this pull request Apr 30, 2024
jesuyedavid added a commit that referenced this pull request May 1, 2024
Remove Node 16 deprecation warnings (#37, #38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants