Skip to content

Commit

Permalink
Merge main into v1
Browse files Browse the repository at this point in the history
Remove Node 16 deprecation warnings (#37, #38)
  • Loading branch information
jesuyedavid authored May 1, 2024
2 parents 91403e5 + a4e6207 commit 1c38f5d
Show file tree
Hide file tree
Showing 12 changed files with 28 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @yext/slapshot
* @yext/watson
17 changes: 9 additions & 8 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ jobs:
outputs:
coverage-percent: ${{ steps.parse-coverage.outputs.coverage-percent }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ inputs.comparison_branch }}
- name: Use Node.js 16.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
registry-url: 'https://registry.npmjs.org'
Expand All @@ -52,9 +52,9 @@ jobs:
outputs:
coverage-percent: ${{ steps.parse-coverage.outputs.coverage-percent }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js 16.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
registry-url: 'https://registry.npmjs.org'
Expand All @@ -69,7 +69,7 @@ jobs:
id: parse-coverage
- run: echo current coverage is ${{ steps.parse-coverage.outputs.coverage-percent }}%
- name: Upload lcov build artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
path: coverage/
Expand All @@ -78,7 +78,7 @@ jobs:
runs-on: ubuntu-latest
needs: [base-coverage, current-coverage]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Check if percent is too low
run: |
percentIsTooLow=$(echo ${{ needs.base-coverage.outputs.coverage-percent }} ${{ needs.current-coverage.outputs.coverage-percent }} |
Expand All @@ -89,11 +89,12 @@ jobs:
exit 1
fi
- name: Download the current coverage
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: coverage
path: coverage/
- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
with:
file: coverage/lcov.info
github-token: ${{ secrets.caller_github_token }}
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ jobs:
image: returntocorp/semgrep
if: (github.actor != 'dependabot[bot]')
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: semgrep ci
4 changes: 2 additions & 2 deletions .github/workflows/percy_snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ jobs:
percy_snapshots:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: ${{ inputs.fetch_depth }}
- name: Use Node.js 16.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
- run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
- run: npm ci
- run: ${{ inputs.lint_script }}
4 changes: 2 additions & 2 deletions .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ jobs:
node-version: ${{ fromJSON(inputs.node_matrix) }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
registry-url: 'https://registry.npmjs.org'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync_default_branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
name: Sync branches
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Sync ${{ github.event.repository.default_branch }} with ${{ inputs.target_branch }}
uses: devmasx/merge-branch@v1.4.0
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sync_develop_and_main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
create_pull_request:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Extract version and merge branch name
id: vars
run: |
Expand All @@ -23,7 +23,7 @@ jobs:
echo tag=${PACKAGE_VERSION} >> $GITHUB_OUTPUT
echo merge_branch_name="dev/merge-${PACKAGE_VERSION}-${COMMIT_HASH}-into-develop" >> $GITHUB_OUTPUT
- name: Create merge branch
uses: peterjgrainger/action-create-branch@v2.4.0
uses: peterjgrainger/action-create-branch@v3.0.0
with:
branch: ${{ steps.vars.outputs.merge_branch_name }}
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/third_party_notices_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ jobs:
license-check:
runs-on: ${{ inputs.environment }}
steps:
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 16.x
registry-url: 'https://registry.npmjs.org'
- run: npm install -g generate-license-file@1
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}
token: ${{ secrets.REPO_SCOPED_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
update-docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}
token: ${{ secrets.REPO_SCOPED_TOKEN }}
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 16.x
- run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/version_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
update-version:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- name: update package version
id: vars
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/wcag_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
WCAG-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: ${{ inputs.fetch_depth }}
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 16.x
registry-url: 'https://registry.npmjs.org'
Expand Down

0 comments on commit 1c38f5d

Please sign in to comment.