ksearch: adjust id generation to add basename from callers #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adjusts our useId function, which generates ids for html elements, to also take a 'basename' argument from callers. This is to help reduce the likelihood of an id made conflicting with an id somewhere else on the page. J=WAT-4464 TEST=auto Ran tests. Was having issues getting the test site running
|
Current unit coverage is 92.12481426448737% |
k-gerner
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts our useId function, which generates ids for html elements, to also take a 'basename' argument from callers. This is to help reduce the likelihood of an id made conflicting with an id somewhere else on the page.
J=WAT-4464
TEST=auto
Ran tests. Was having issues getting the test site running