Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksearch: adjust id generation to add basename from callers #471

Merged
merged 2 commits into from
Oct 17, 2024
Merged

ksearch: adjust id generation to add basename from callers #471

merged 2 commits into from
Oct 17, 2024

Commits on Oct 17, 2024

  1. ksearch: adjust id generation to add basename from callers 

    This PR adjusts our useId function, which generates ids for
html elements, to also take a 'basename' argument from
callers. This is to help reduce the likelihood of an id
made conflicting with an id somewhere else on the page.

J=WAT-4464
TEST=auto

Ran tests. Was having issues getting the test site running
    @Fondryext
    Fondryext committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c6a426f View commit details
    Browse the repository at this point in the history

  2. Update snapshots

    @github-actions
    github-actions[bot] committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    bbf9f63 View commit details
    Browse the repository at this point in the history