Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.5 #472

Merged
merged 3 commits into from
Oct 17, 2024
Merged

v1.6.5 #472

merged 3 commits into from
Oct 17, 2024

Conversation

Fondryext
Copy link
Contributor

Fixes

github-actions bot and others added 3 commits October 17, 2024 13:57
This PR adjusts our useId function, which generates ids for
html elements, to also take a 'basename' argument from
callers. This is to help reduce the likelihood of an id
made conflicting with an id somewhere else on the page.

J=WAT-4464
TEST=auto

Ran tests. Was having issues getting the test site running

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@Fondryext Fondryext requested a review from a team as a code owner October 17, 2024 19:30
@coveralls
Copy link

Coverage Status

coverage: 85.38%. remained the same
when pulling 1c102c5 on hotfix/v1.6.5
into fa0b741 on main.

Copy link
Contributor

Current unit coverage is 92.12481426448737%
Current visual coverage is 79.01234567901234%
Current combined coverage is 92.62376237623762%

@Fondryext Fondryext merged commit 76fb682 into main Oct 17, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants