Search Rate Tracking #1558
Merged
Search Rate Tracking #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
reviewed
Sep 29, 2021
src/answers-umd.js
Outdated
| if (!this.components.getActiveComponent(SearchComponent.type)) { | ||
| this._initQueryUpdateListener(parsedConfig.search); | ||
| } | ||
|
|
||
| const impressionEvent = createImpressionEvent({ |
There was a problem hiding this comment.
Here, do we need to look at what components are on the actual page first? If there is no SearchBar component on the page, do we fire an impression event? It's also possible that someone could pull down the full SDK and only instantiate a SearchBar component. In that case, should we send standAlone is true?
There was a problem hiding this comment.
Those are good points. I'll make some updates
There was a problem hiding this comment.
Updated. I'm assuming that the standalone assets will always put the search bar on the page, so those assets will always set standalone: true
tmeyer2115
approved these changes
Sep 30, 2021
Merged
nmanu1
added a commit
that referenced
this pull request
Nov 16, 2021
## Version 1.12.0 ### Features - Allow search rate tracking (#1558) - Add support for setting and changing the visitor and passing it to answers-core (#1564) - Add support for the auth token that is passed in from the config (#1566) - Add an `environment` field to support consumer auth in Sandbox (#1597) - Allow components to override the beforeMount function (#1547) - Add distance to the card data and a function to format it (#1550) - WCAG updates (allow pagination with Enter (#1575), identify current page in navigation tab (#1576), update autocomplete screen reader support (#1578, #1579)) ### Changes - Update directAnswers component data to include the searcher (#1596) - Use custom alerts instead of window.alert (#1549) - Update Mapbox version to match the Theme (#1551) - Internal repo changes (#1562, #1577) ### Bugfixes - Fix console error which would appear on google maps (#1548) - Fix FAQ expansion when default is expanded (#1553) - Fix error for searches on page load with no businessId (#1561)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow search rate tracking by sending impression analytics events when the experience loads
J=SLAP-1600
TEST=manual, integration
View the network tab and see that the answers impression event is fired on load. For the search bar only assets, see that 'standAlone' is true. Also see that 'standaAlone' is true if the regular SDK assets are used but only the search bar component is added to the page. Confirm the other fields are included such as experienceKey, experienceVersion, searcher, and verticalConfigId. Add integration test which confirms that the report function is called properly for both the standard integration and the search bar integration