Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SDK Mapbox to same version as Theme #1551

Merged
merged 1 commit into from
Sep 21, 2021
Merged

update SDK Mapbox to same version as Theme #1551

merged 1 commit into from
Sep 21, 2021

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Sep 21, 2021

  • updated version to v1.13.1 for Mapbox js and css api
  • checked that there's no breaking change with the version update
  • confirmed with product of the change in pricing model

TEST=manual

  • add map to universal search component on page, serve page using locale answer bundle and see that mapbox work properly
  • test that dark-v10 style works for mapbox

update SDK Mapbox to same version as Theme
e3014e6 
- updated version to v1.13.1 for Mapbox js and css api
- checked that there's no breaking change with the version update
- confirmed with product of the change in pricing model

TEST=manual
- add map to universal search, and see that mapbox work properly
- test that dark-v10 style works for mapbox
tmeyer2115
tmeyer2115 approved these changes Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@tmeyer2115 tmeyer2115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should just make sure we get the okay from Rose on the pricing.

@yen-tt
Copy link
Contributor Author

yen-tt commented Sep 21, 2021

LGTM, we should just make sure we get the okay from Rose on the pricing.

She said it's fine to proceed with the change

@yen-tt yen-tt merged commit 32f0b2f into develop Sep 21, 2021
@yen-tt yen-tt deleted the dev/update-mapbox branch September 21, 2021 18:36
@nmanu1 nmanu1 mentioned this pull request Nov 16, 2021
Merged
nmanu1 added a commit that referenced this pull request Nov 16, 2021
@nmanu1
Version 1.12 (#1604)
bb58f00 
## Version 1.12.0
### Features
- Allow search rate tracking (#1558)
- Add support for setting and changing the visitor and passing it to answers-core (#1564)
- Add support for the auth token that is passed in from the config (#1566)
- Add an `environment` field to support consumer auth in Sandbox (#1597)
- Allow components to override the beforeMount function (#1547)
- Add distance to the card data and a function to format it (#1550)
- WCAG updates (allow pagination with Enter (#1575), identify current page in navigation tab (#1576), update autocomplete screen reader support (#1578, #1579))

### Changes
- Update directAnswers component data to include the searcher (#1596)
- Use custom alerts instead of window.alert (#1549)
- Update Mapbox version to match the Theme (#1551)
- Internal repo changes (#1562, #1577)

### Bugfixes
- Fix console error which would appear on google maps (#1548)
- Fix FAQ expansion when default is expanded (#1553)
- Fix error for searches on page load with no businessId (#1561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeyer2115 tmeyer2115 tmeyer2115 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yen-tt @tmeyer2115