custom alert replace window.alert #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use alertifyJS library to provide framework for browser dialogs and notifications. - Add alertifyJS library css and some custom css (to match with current window popup UI) to answers.scss - update all window.alert calls to use alertify.alert - expose this reference of AlertifyJS library so Theme can use it too, without the library setup to be in two repos J=SLAP-1524 TEST=manual - serve page using voicesearch functionality with mic access block, see that an alert is display on page with proper UI - check with screen reader and see that the popup message and button can be read (although, there's some hidden buttons that would need to be skipped over)
|
Unfortunately we can't use alertifyJS because it uses the GPL-3.0 License which is a copyleft license which forces us to follow certain conditions. The licenses pre-approved by legal are MIT, BSD 2, BSD 3, and Apache. |
cea2aj
reviewed
Sep 20, 2021
cea2aj
reviewed
Sep 20, 2021
|
Window popup: |
cea2aj
reviewed
Sep 20, 2021
cea2aj
approved these changes
Sep 20, 2021
oshi97
approved these changes
Sep 20, 2021
sweetalert2 is forked off sweetalert when there was a period it wasn't being maintained. From the documentation, sweetalert2 seems to have more configuration and themes options, but it is a bigger package. For our purpose, I think sweetalert should be sufficient! |
Merged
nmanu1
added a commit
that referenced
this pull request
Nov 16, 2021
## Version 1.12.0 ### Features - Allow search rate tracking (#1558) - Add support for setting and changing the visitor and passing it to answers-core (#1564) - Add support for the auth token that is passed in from the config (#1566) - Add an `environment` field to support consumer auth in Sandbox (#1597) - Allow components to override the beforeMount function (#1547) - Add distance to the card data and a function to format it (#1550) - WCAG updates (allow pagination with Enter (#1575), identify current page in navigation tab (#1576), update autocomplete screen reader support (#1578, #1579)) ### Changes - Update directAnswers component data to include the searcher (#1596) - Use custom alerts instead of window.alert (#1549) - Update Mapbox version to match the Theme (#1551) - Internal repo changes (#1562, #1577) ### Bugfixes - Fix console error which would appear on google maps (#1548) - Fix FAQ expansion when default is expanded (#1553) - Fix error for searches on page load with no businessId (#1561)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=SLAP-1524
TEST=manual