-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styling for items in More tab #989
Conversation
static/scss/answers/theme.scss
Outdated
@@ -67,6 +67,9 @@ | |||
padding-left: var(--yxt-base-spacing); | |||
padding-right: var(--yxt-base-spacing); | |||
padding-bottom: calc(var(--yxt-base-spacing) * 0.2); | |||
padding-top: calc(var(--yxt-base-spacing) * 0.5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would double check with Rose that they want the padding-top
even on the first item in the "More" drop-down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with Rose and she said that the padding-top
should not be applied to the first item, so I will change that
## Version 1.26.0 ### Features - Add support for the auth token, with a new global_config `token` field (#976) - Add support for the visitor, which can be set or changed at runtime (#970) - Add support for generic thumbs up/down feedback buttons to all cards (#973, #1005) - Handle page and template names with spaces (#988) ### Changes - Update styling of navigation ‘More’ menu (#989) - Update hover color of search bar buttons (#1000) - Internal repo changes (automate WCAG testing (#987)) ### Bugfixes - Fix console error which would appear on google maps (#955) - Fix extra query when loading in iframe integrations (#986) - Fix bug that displayed links that didn’t exist (#990) - Allow microphone access for voice search in iframe (#991) - Fix issue with custom search icon size (#992) - Fix bug with new prop comments not being added (#1004) - Fix distance alignment on location cards (#1006)
Update padding, line-height, and word break of navigation items in the 'More' tab. The padding should not apply to the first item in the list.
J=SLAP-1662
TEST=manual
Check that styling changes are present and the break occurs correctly with multiple word items.