Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visitor support #970

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Add visitor support #970

merged 3 commits into from
Oct 11, 2021

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Oct 8, 2021

Add a runtime config listener for changes to visitor.

J=SLAP-1621
TEST=auto, manual

Add jest test for visitor listener and check in test-site if visitor is sent in analytics events and searches in standard and iframe integration.

@coveralls
Copy link

coveralls commented Oct 8, 2021

Coverage Status

Coverage increased (+0.2%) to 9.006% when pulling be24be7 on dev/visitor-support into 306e3ab on develop.

global_config.json Outdated Show resolved Hide resolved
@nmanu1 nmanu1 merged commit d9bf111 into develop Oct 11, 2021
tmeyer2115 added a commit that referenced this pull request Oct 13, 2021
cea2aj added a commit that referenced this pull request Oct 14, 2021
@nmanu1 nmanu1 mentioned this pull request Nov 16, 2021
nmanu1 added a commit that referenced this pull request Nov 16, 2021
## Version 1.26.0
### Features
- Add support for the auth token, with a new global_config `token` field  (#976)
- Add support for the visitor, which can be set or changed at runtime (#970)
- Add support for generic thumbs up/down feedback buttons to all cards (#973, #1005)
- Handle page and template names with spaces (#988)

### Changes
- Update styling of navigation ‘More’ menu (#989)
- Update hover color of search bar buttons (#1000)
- Internal repo changes (automate WCAG testing (#987))

### Bugfixes
- Fix console error which would appear on google maps (#955)
- Fix extra query when loading in iframe integrations (#986)
- Fix bug that displayed links that didn’t exist (#990)
- Allow microphone access for voice search in iframe (#991)
- Fix issue with custom search icon size (#992)
- Fix bug with new prop comments not being added (#1004)
- Fix distance alignment on location cards (#1006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants