add missing prop comments when merging global configs on upgrade #1004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where new prop comments would not be added to a user's
global config on upgrade. This issue occurred due to how comment-json
stores comments in CommentToken arrays. Each CommentToken[] is associated
with a symbol determined by the closest json property, such as
Symbol.for('before:sessionTracking)
.During a comment-json assign, CommentToken arrays associated with the same symbol
are not magically merged with no duplicates. Instead, the higher priority json will override the other.
This was fixed by re-adding in any missing comments.
No guarantees are made about the exact locations of re-added comments, to avoid
risk associated with a larger rework. I re-added them to the front for now, because
that works the best for the specific issue pointed out ("token" missing").
J=SLAP-1694
TEST=manual,auto
jambo upgrade, saw token added to my global config