Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.25.0 #979

Merged
merged 27 commits into from
Oct 13, 2021
Merged

Version 1.25.0 #979

merged 27 commits into from
Oct 13, 2021

Commits on Sep 14, 2021

  1. Merge master (v1.24.0) into develop (#953)

    Merge master (v1.24.0) into develop
    cea2aj authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    35bfa38 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Fix google maps InvalidValueError in theme (#955)

    - SDK GoogleMapMarkerConfig expects label to be of type string
    
    J=SLAP-655
    TEST=manual
    
    see that map is working properly and error is gone in browser inspector
    yen-tt authored Sep 16, 2021
    Configuration menu
    Copy the full SHA
    b80ba4c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. avoid results render on locator map view (#954)

    Improve performance for map pages on mobile by only render result cards on list view
    
    - VerticalFullPageMapOrchestrator use a field in core storage `DISABLE_RENDER_RESULTS` to communicate with VerticalResults component whether it should render the results on page.
    - VerticalResults component's config pass in a beforeMountOverride function to avoid mount() being call in the component lifecycle and render if `DISABLE_RENDER_RESULTS` is true.
    - VerticalResults component's config also pass in a onCreate function to add a listener on any changes `DISABLE_RENDER_RESULTS`, to potentially trigger render update for the rsults if user switch from map view to list view, or screen resize between mobile and desktop view
    - Since VerticalResults now will not render any location cards on map view, VerticalFullPageOrchestrator can no longer copy the card and display that when a pin is clicked. So,cardType is passed into the config for VerticalFullPageOrchestrator. When a pin is click, the cardId is used to pull the corresponding entity data from results in storage, and construct a card component based on cardType to append to the top level map container.
    
    Note: require update to SDK's component.js file for beforeMountOverride to work
    
    J=SLAP-1302
    TEST=manual & auto
    
    smoke test from theme's locations_full_page_map vertical page:
    - resize screen from mobile to desktop and vice versa, see that results and focused pins are still loaded properly.
    - toggle between map and list view, see that the results are only render on list view in elemnt inspection (except for the first time when search is trigger from searchbar)
    - in map view, drag across the map a few times and see that pins are loaded correctly but results are not render on the page.
    - see that detail card is displayed correctly when click on pin from map view, before and after dragging acrross the map
    
    recorded performance metric on browser inspector, see that the tasks to re-render the components shrink to around ~≤27ms compare to previous time depending on result count (~≥100ms for 2000+ results) (got rid of most of the 'long tasks' - where the main UI thread is busy for 50 ms or longer)
    
    no changes in map related snapshots from percy
    yen-tt authored Sep 17, 2021
    Configuration menu
    Copy the full SHA
    299baa2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. remove unused file (#956)

    - when checking usage of window.alert for theme, this is the only place that uses it. But since this class/file is not being used anywhere, we should remove it.
    yen-tt authored Sep 20, 2021
    Configuration menu
    Copy the full SHA
    351737c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Distance formatter to include locale with region (#957)

    Int.FormatNumber and toLocaleString would fail on locale with underscore, such as chinese locale like 'zh-Hant_CN'. Update function to replace underscore with dash for locale
    
    TEST=auto
    
    pass updated jest test
    yen-tt authored Sep 23, 2021
    Configuration menu
    Copy the full SHA
    d4c6755 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Automate PR from master to develp (#959)

    - add github action to create pr from master/main to develop on push to master/main (yml file from generator-slapshot repo)
    
    J=SLAP-1357
    yen-tt authored Sep 24, 2021
    Configuration menu
    Copy the full SHA
    80cc081 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Configuration menu
    Copy the full SHA
    51fefaf View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. dont hide ANSWERS.onReady errors (#964)

    Prior to this change, all errors that occurred during ANSWERS.onReady
    were being swallowed up by the .catch(). This could lead to very
    frustrating debugging experiences, and also hide critical errors like
    a null pointer error.
    
    J=SLAP-1616
    TEST=manual
    
    see that errors are no longer hidden
    oshi97 authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    b98b549 View commit details
    Browse the repository at this point in the history
  2. Update vertical-grid config (#965)

    Add `verticalLimit` and `universalLimit` to vertical-grid's page-config.json, and have them commented out as default.
    
    J=SLAP-1618
    TEST=none
    nmanu1 authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    092a19f View commit details
    Browse the repository at this point in the history
  3. add apiKey validation when using injected data and useJWT=false (#962)

    J=TECHOPS-2183
    TEST=manual
    
    tested using my local JAMBO_INJECTED DATA
    tested that errors are emitted when using the deprecated injected api key, but the build continues
    tested that the build throws an error when no production or deprecated api key exist
    oshi97 authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    350ca68 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Comment out vertical icons (#967)

    Comment out vertical icons per the HH's request
    
    With this change, Icons will no longer appear next to the names of verticals on the universal page by default
    
    J=SLAP-1619
    TEST=manual, visual
    
    Build the local test site and see that icons are no longer there except for where a custom icon url is supplied
    cea2aj authored Oct 7, 2021
    Configuration menu
    Copy the full SHA
    4eda44d View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. add sorting facets by optionsOrder (#968)

    J=SLAP-1631
    TEST=manual,auto
    
    saw facets were sorted on the people page
    oshi97 authored Oct 8, 2021
    Configuration menu
    Copy the full SHA
    306e3ab View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Add visitor support (#970)

    Add a runtime config listener for changes to `visitor`.
    
    J=SLAP-1621
    TEST=auto, manual
    
    Add jest test for visitor listener and check in test-site if `visitor` is sent in analytics events and searches in standard and iframe integration.
    nmanu1 authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    d9bf111 View commit details
    Browse the repository at this point in the history
  2. handle different optionsFieldType (#971)

    Originally, I thought running a toString() on the displayName would handle number display names.
    But, string.prototype.localeCompare doesn't work with number strings the way I hoped it would.
    If you try to sort an array of numbers like [100, 20, 120], the result will be [100, 120, 20] rather than
    the expected [20, 100, 120].
    My unit tests only had single digit numbers, so they didn't run test that case.
    
    TEST=auto
    J=SLAP-1631
    oshi97 authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    c288da5 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Add generic thumbs up/down (#973)

    Add generic thumbs up/down feedback buttons and analytics to all cards (#938, #939, #940).
    
    - Include a `feedback` config option in `dataForRender` so user can specify if feedback buttons should appear on the card or not.
    - Create a shared partial for the buttons that is used in all cards, including direct answer cards
    - Update analytics for direct answer feedback with additional event attributes.
    
    J=SLAP-1544, 1545
    TEST=manual
    
    Smoke testing to see if thumbs up/down buttons function as expected on all cards and send analytics.
    nmanu1 authored Oct 12, 2021
    Configuration menu
    Copy the full SHA
    d3d591b View commit details
    Browse the repository at this point in the history
  2. support sorting facets using optionsOrderList (#972)

    I changed the sorting to not mutate the original array.
    Originally I was worried about performance, but it should be very minor.
    
    J=SLAP-1632
    TEST=manual,auto
    
    added optionsOrderList to the people page's config override for percy snapshots
    manually built the page and saw the facets being sorted
    oshi97 authored Oct 12, 2021
    Configuration menu
    Copy the full SHA
    9780194 View commit details
    Browse the repository at this point in the history
  3. remove optionsFieldType (#974)

    The backend does not natively support facets on number fields.
    The closest thing that is supported is assuming a string field contains a parseable number.
    This PR removes support for interpreting string fields as numbers, to be consistent with the backend.
    
    J=SLAP-1631
    TEST=manual
    
    rebuilt page and checked optionsOrder and optionsOrderList facets
    oshi97 authored Oct 12, 2021
    Configuration menu
    Copy the full SHA
    0e63ede View commit details
    Browse the repository at this point in the history
  4. Use color-text-primary for card body text (#966)

    Use the color-text-primary variable for the color of text on the body of cards
    
    This change makes most text slightly lighter because the value of --yxt-color-text-primary is `#212121;`. Previously the cards were falling back to the default of the browser which is black.
    
    The item mentioned using the text mixin to accomplish this, however I decided to use the variable directly because there is less chance of side effects because the text mixin affects things other than color.
    
    J=SLAP-1617
    TEST=manual
    
    For testing purposes, set the text to red and view all of the cards of the test site. See that the color of the body of text is red as expected.
    cea2aj authored Oct 12, 2021
    Configuration menu
    Copy the full SHA
    c96c5f1 View commit details
    Browse the repository at this point in the history
  5. Fix feedback analytics (#975)

    Only show thumbs up/down feedback buttons when user provides `businessId` and enables analytics.
    
    J=SLAP-1175
    TEST=manual
    
    Smoke testing to check if feedback buttons only appear when expected.
    nmanu1 authored Oct 12, 2021
    Configuration menu
    Copy the full SHA
    646c166 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Revert "Add visitor support (#970)"

    This reverts commit d9bf111.
    tmeyer2115 authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    373774d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #977 from yext/revert-970-dev/visitor-support

    Revert "Add visitor support"
    tmeyer2115 authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    c4df598 View commit details
    Browse the repository at this point in the history
  3. Update version to v1.25.

    tmeyer2115 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    f7a18e6 View commit details
    Browse the repository at this point in the history
  4. Revert "Fix feedback analytics (#975)"

    This reverts commit 646c166.
    nmanu1 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    63c1833 View commit details
    Browse the repository at this point in the history
  5. Revert "Add generic thumbs up/down (#973)"

    This reverts commit d3d591b.
    nmanu1 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    de779cd View commit details
    Browse the repository at this point in the history
  6. Fix DA cards feedback analytics (#978)

    Only show thumbs up/down feedback buttons on direct answer cards when user provides `businessId` and enables analytics.
    
    J=SLAP-1175
    TEST=manual
    
    Smoke testing to check if feedback buttons only appear on DA cards when expected.
    nmanu1 authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    dd89e78 View commit details
    Browse the repository at this point in the history
  7. Revert 'Fix google maps InvalidValueError in theme' (#981)

    Reverts  #955 because the necessary corresponding [PR in the SDK](yext/answers-search-ui#1548) didn't make it into v1.11
    
    J=none
    TEST=manual
    
    Build the test site with the new v1.11 SDK and see that the icons now look correct
    cea2aj authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    0e31bd3 View commit details
    Browse the repository at this point in the history
  8. Update to Jambo v1.12.1 and SDK v1.11 (#980)

    Update to Jambo v1.12.1 and SDK v1.11
    cea2aj authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    6bd66b8 View commit details
    Browse the repository at this point in the history