-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.25.0 #979
Version 1.25.0 #979
Commits on Sep 14, 2021
-
Merge master (v1.24.0) into develop (#953)
Merge master (v1.24.0) into develop
Configuration menu - View commit details
-
Copy full SHA for 35bfa38 - Browse repository at this point
Copy the full SHA 35bfa38View commit details
Commits on Sep 16, 2021
-
Fix google maps InvalidValueError in theme (#955)
- SDK GoogleMapMarkerConfig expects label to be of type string J=SLAP-655 TEST=manual see that map is working properly and error is gone in browser inspector
Configuration menu - View commit details
-
Copy full SHA for b80ba4c - Browse repository at this point
Copy the full SHA b80ba4cView commit details
Commits on Sep 17, 2021
-
avoid results render on locator map view (#954)
Improve performance for map pages on mobile by only render result cards on list view - VerticalFullPageMapOrchestrator use a field in core storage `DISABLE_RENDER_RESULTS` to communicate with VerticalResults component whether it should render the results on page. - VerticalResults component's config pass in a beforeMountOverride function to avoid mount() being call in the component lifecycle and render if `DISABLE_RENDER_RESULTS` is true. - VerticalResults component's config also pass in a onCreate function to add a listener on any changes `DISABLE_RENDER_RESULTS`, to potentially trigger render update for the rsults if user switch from map view to list view, or screen resize between mobile and desktop view - Since VerticalResults now will not render any location cards on map view, VerticalFullPageOrchestrator can no longer copy the card and display that when a pin is clicked. So,cardType is passed into the config for VerticalFullPageOrchestrator. When a pin is click, the cardId is used to pull the corresponding entity data from results in storage, and construct a card component based on cardType to append to the top level map container. Note: require update to SDK's component.js file for beforeMountOverride to work J=SLAP-1302 TEST=manual & auto smoke test from theme's locations_full_page_map vertical page: - resize screen from mobile to desktop and vice versa, see that results and focused pins are still loaded properly. - toggle between map and list view, see that the results are only render on list view in elemnt inspection (except for the first time when search is trigger from searchbar) - in map view, drag across the map a few times and see that pins are loaded correctly but results are not render on the page. - see that detail card is displayed correctly when click on pin from map view, before and after dragging acrross the map recorded performance metric on browser inspector, see that the tasks to re-render the components shrink to around ~≤27ms compare to previous time depending on result count (~≥100ms for 2000+ results) (got rid of most of the 'long tasks' - where the main UI thread is busy for 50 ms or longer) no changes in map related snapshots from percy
Configuration menu - View commit details
-
Copy full SHA for 299baa2 - Browse repository at this point
Copy the full SHA 299baa2View commit details
Commits on Sep 20, 2021
-
- when checking usage of window.alert for theme, this is the only place that uses it. But since this class/file is not being used anywhere, we should remove it.
Configuration menu - View commit details
-
Copy full SHA for 351737c - Browse repository at this point
Copy the full SHA 351737cView commit details
Commits on Sep 23, 2021
-
Distance formatter to include locale with region (#957)
Int.FormatNumber and toLocaleString would fail on locale with underscore, such as chinese locale like 'zh-Hant_CN'. Update function to replace underscore with dash for locale TEST=auto pass updated jest test
Configuration menu - View commit details
-
Copy full SHA for d4c6755 - Browse repository at this point
Copy the full SHA d4c6755View commit details
Commits on Sep 24, 2021
-
Automate PR from master to develp (#959)
- add github action to create pr from master/main to develop on push to master/main (yml file from generator-slapshot repo) J=SLAP-1357
Configuration menu - View commit details
-
Copy full SHA for 80cc081 - Browse repository at this point
Copy the full SHA 80cc081View commit details
Commits on Sep 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 51fefaf - Browse repository at this point
Copy the full SHA 51fefafView commit details
Commits on Oct 4, 2021
-
dont hide ANSWERS.onReady errors (#964)
Prior to this change, all errors that occurred during ANSWERS.onReady were being swallowed up by the .catch(). This could lead to very frustrating debugging experiences, and also hide critical errors like a null pointer error. J=SLAP-1616 TEST=manual see that errors are no longer hidden
Configuration menu - View commit details
-
Copy full SHA for b98b549 - Browse repository at this point
Copy the full SHA b98b549View commit details -
Update vertical-grid config (#965)
Add `verticalLimit` and `universalLimit` to vertical-grid's page-config.json, and have them commented out as default. J=SLAP-1618 TEST=none
Configuration menu - View commit details
-
Copy full SHA for 092a19f - Browse repository at this point
Copy the full SHA 092a19fView commit details -
add apiKey validation when using injected data and useJWT=false (#962)
J=TECHOPS-2183 TEST=manual tested using my local JAMBO_INJECTED DATA tested that errors are emitted when using the deprecated injected api key, but the build continues tested that the build throws an error when no production or deprecated api key exist
Configuration menu - View commit details
-
Copy full SHA for 350ca68 - Browse repository at this point
Copy the full SHA 350ca68View commit details
Commits on Oct 7, 2021
-
Comment out vertical icons (#967)
Comment out vertical icons per the HH's request With this change, Icons will no longer appear next to the names of verticals on the universal page by default J=SLAP-1619 TEST=manual, visual Build the local test site and see that icons are no longer there except for where a custom icon url is supplied
Configuration menu - View commit details
-
Copy full SHA for 4eda44d - Browse repository at this point
Copy the full SHA 4eda44dView commit details
Commits on Oct 8, 2021
-
add sorting facets by optionsOrder (#968)
J=SLAP-1631 TEST=manual,auto saw facets were sorted on the people page
Configuration menu - View commit details
-
Copy full SHA for 306e3ab - Browse repository at this point
Copy the full SHA 306e3abView commit details
Commits on Oct 11, 2021
-
Add a runtime config listener for changes to `visitor`. J=SLAP-1621 TEST=auto, manual Add jest test for visitor listener and check in test-site if `visitor` is sent in analytics events and searches in standard and iframe integration.
Configuration menu - View commit details
-
Copy full SHA for d9bf111 - Browse repository at this point
Copy the full SHA d9bf111View commit details -
handle different optionsFieldType (#971)
Originally, I thought running a toString() on the displayName would handle number display names. But, string.prototype.localeCompare doesn't work with number strings the way I hoped it would. If you try to sort an array of numbers like [100, 20, 120], the result will be [100, 120, 20] rather than the expected [20, 100, 120]. My unit tests only had single digit numbers, so they didn't run test that case. TEST=auto J=SLAP-1631
Configuration menu - View commit details
-
Copy full SHA for c288da5 - Browse repository at this point
Copy the full SHA c288da5View commit details
Commits on Oct 12, 2021
-
Add generic thumbs up/down (#973)
Add generic thumbs up/down feedback buttons and analytics to all cards (#938, #939, #940). - Include a `feedback` config option in `dataForRender` so user can specify if feedback buttons should appear on the card or not. - Create a shared partial for the buttons that is used in all cards, including direct answer cards - Update analytics for direct answer feedback with additional event attributes. J=SLAP-1544, 1545 TEST=manual Smoke testing to see if thumbs up/down buttons function as expected on all cards and send analytics.
Configuration menu - View commit details
-
Copy full SHA for d3d591b - Browse repository at this point
Copy the full SHA d3d591bView commit details -
support sorting facets using optionsOrderList (#972)
I changed the sorting to not mutate the original array. Originally I was worried about performance, but it should be very minor. J=SLAP-1632 TEST=manual,auto added optionsOrderList to the people page's config override for percy snapshots manually built the page and saw the facets being sorted
Configuration menu - View commit details
-
Copy full SHA for 9780194 - Browse repository at this point
Copy the full SHA 9780194View commit details -
remove optionsFieldType (#974)
The backend does not natively support facets on number fields. The closest thing that is supported is assuming a string field contains a parseable number. This PR removes support for interpreting string fields as numbers, to be consistent with the backend. J=SLAP-1631 TEST=manual rebuilt page and checked optionsOrder and optionsOrderList facets
Configuration menu - View commit details
-
Copy full SHA for 0e63ede - Browse repository at this point
Copy the full SHA 0e63edeView commit details -
Use color-text-primary for card body text (#966)
Use the color-text-primary variable for the color of text on the body of cards This change makes most text slightly lighter because the value of --yxt-color-text-primary is `#212121;`. Previously the cards were falling back to the default of the browser which is black. The item mentioned using the text mixin to accomplish this, however I decided to use the variable directly because there is less chance of side effects because the text mixin affects things other than color. J=SLAP-1617 TEST=manual For testing purposes, set the text to red and view all of the cards of the test site. See that the color of the body of text is red as expected.
Configuration menu - View commit details
-
Copy full SHA for c96c5f1 - Browse repository at this point
Copy the full SHA c96c5f1View commit details -
Only show thumbs up/down feedback buttons when user provides `businessId` and enables analytics. J=SLAP-1175 TEST=manual Smoke testing to check if feedback buttons only appear when expected.
Configuration menu - View commit details
-
Copy full SHA for 646c166 - Browse repository at this point
Copy the full SHA 646c166View commit details
Commits on Oct 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 373774d - Browse repository at this point
Copy the full SHA 373774dView commit details -
Merge pull request #977 from yext/revert-970-dev/visitor-support
Revert "Add visitor support"
Configuration menu - View commit details
-
Copy full SHA for c4df598 - Browse repository at this point
Copy the full SHA c4df598View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7a18e6 - Browse repository at this point
Copy the full SHA f7a18e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c1833 - Browse repository at this point
Copy the full SHA 63c1833View commit details -
Revert "Add generic thumbs up/down (#973)"
This reverts commit d3d591b.
Configuration menu - View commit details
-
Copy full SHA for de779cd - Browse repository at this point
Copy the full SHA de779cdView commit details -
Fix DA cards feedback analytics (#978)
Only show thumbs up/down feedback buttons on direct answer cards when user provides `businessId` and enables analytics. J=SLAP-1175 TEST=manual Smoke testing to check if feedback buttons only appear on DA cards when expected.
Configuration menu - View commit details
-
Copy full SHA for dd89e78 - Browse repository at this point
Copy the full SHA dd89e78View commit details -
Revert 'Fix google maps InvalidValueError in theme' (#981)
Reverts #955 because the necessary corresponding [PR in the SDK](yext/answers-search-ui#1548) didn't make it into v1.11 J=none TEST=manual Build the test site with the new v1.11 SDK and see that the icons now look correct
Configuration menu - View commit details
-
Copy full SHA for 0e31bd3 - Browse repository at this point
Copy the full SHA 0e31bd3View commit details -
Update to Jambo v1.12.1 and SDK v1.11 (#980)
Update to Jambo v1.12.1 and SDK v1.11
Configuration menu - View commit details
-
Copy full SHA for 6bd66b8 - Browse repository at this point
Copy the full SHA 6bd66b8View commit details