dont hide ANSWERS.onReady errors #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, all errors that occurred during ANSWERS.onReady were being swalloed up by the .catch(). This could lead to very frustrating debugging experiences, and also hide critial errors like a null pointer error. J=SLAP-1616 TEST=manual see that errors are no longer hidden
|
acceptance tests will fail until yext/answers-search-ui#1561 is merged in |
yen-tt
approved these changes
Oct 1, 2021
cea2aj
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, all errors that occurred during ANSWERS.onReady
were being swallowed up by the .catch(). This could lead to very
frustrating debugging experiences, and also hide critical errors like
a null pointer error.
J=SLAP-1616
TEST=manual
see that errors are no longer hidden