#460 Bring back implementation of Folded #477
Conversation
|
@yegor256 please, pay attention to this pull request |
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
============================================
+ Coverage 67.36% 67.48% +0.12%
- Complexity 992 996 +4
============================================
Files 207 208 +1
Lines 3429 3442 +13
Branches 254 256 +2
============================================
+ Hits 2310 2323 +13
Misses 1048 1048
Partials 71 71
Continue to review full report at Codecov.
|
|
Job |
|
@bedward70 can't you just provide |
|
@yegor256 I double-checked and did not see the way to unite
|
|
@rultor merge |
@bedward70 @yegor256 Oops, I failed. You can see the full log here (spent 8min) |
|
@llorllale I have done. I split the PR to 3 PRs:
|
| * | ||
| * @author Eduard Balovnev (bedward70@mail.ru) | ||
| * @version $Id$ | ||
| * @since 0.10 |
| public final class FoldedTest { | ||
|
|
||
| @Test(expected = NoSuchElementException.class) | ||
| public void emptyListTest() throws Exception { |
There was a problem hiding this comment.
Take a look at the method names of other tests in cactoos to get an idea of how test methods should be named. For example, this one could be called "failsForEmptyIterable"
| "Can't find the single", | ||
| new Folded<>( | ||
| (first, last) -> first, | ||
| new IterableOf<Scalar<Integer>>((Scalar<Integer>) () -> single) |
There was a problem hiding this comment.
There's a lot of "generics" noise in this line (and several others further down). Can the diamond operator be used?
| (first, last) -> first, | ||
| new IterableOf<Scalar<Integer>>((Scalar<Integer>) () -> single) | ||
| ) | ||
| .value(), |
There was a problem hiding this comment.
can you attach this .value() to the closing parenthesis? Do the same for all other occurrences
|
Thank you @bedward70, looks better. Check the comments I just dropped now for a few details regarding the test class. |
|
@bedward70 are you working on this? |
|
@llorllale Yes, but I can't check after java.lang.AssertionError: Can't calculate the file's MD5 checksum java.lang.AssertionError: Can't calculate the file's SHA-1 checksum java.lang.AssertionError: Can't calculate the file's SHA-256 checksum |
|
@bedward70 you're right - |
|
@bedward70 I've opened #580 for this. In the meanwhile, can you work around the error? Perhaps temporarily |
|
@llorllale I have fixed the findings. Thank you for your patience. :) |
|
@yegor256 please merge |
|
The user @llorllale/z resigned from #477, please stop working |
|
@yegor256 I believe this PR is ready to be merged as per the discussion. |
|
@0crat waiting |
|
@driver733 The impediment for #477 was registered successfully by @driver733/z |
|
@0crat status |
|
@yegor256 This is what I know about this job, as in §32:
|
|
@rultor merge |
|
Order was successfully finished: +30 points just awarded to @driver733/z, total is +30 |
|
The job #477 is now out of scope |
After the discussion "#460 Max and Min were renamed to HighestOf and LowestOf to support Comparable implementations #475".
Step 1: Bring back implementation of
FoldedFoldedclass was deleted in the 25dc45d Yegor Bugayenko yegor256@gmail.com on 11/27/17 at 4:05 AM.Foldedclass back.Folded. Details: theFoldedTestclass.