Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*DigestOfTests that work on files are failing on Windows #580

Closed
llorllale opened this issue Jan 26, 2018 · 9 comments
Closed

*DigestOfTests that work on files are failing on Windows #580

llorllale opened this issue Jan 26, 2018 · 9 comments
Labels
bug scope

Comments

@llorllale
Copy link
Contributor

The build is broken on Windows on the following tests:

  • Md5DigestOfTest.checksumFromFile
  • Sha1DigestOfTest.checksumFromFile
  • Sha256DigestOfTest.checksumFromFile

The file checksums simply don't match the expected value.
@0crat
Copy link
Collaborator

0crat commented Jan 26, 2018

@yegor256/z please, pay attention to this issue

@llorllale llorllale mentioned this issue Jan 26, 2018
Merged
@yegor256 yegor256 added the bug label Jan 29, 2018
@0crat 0crat added the scope label Jan 29, 2018
@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

Job #580 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

Bug was reported, see §29: +15 points just awarded to @llorllale/z, total is +330

@0crat
Copy link
Collaborator

0crat commented Feb 1, 2018

The job #580 assigned to @Icok/z. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@0crat
Copy link
Collaborator

0crat commented Feb 6, 2018

@Icok/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

nick318 pushed a commit to nick318/cactoos that referenced this issue Feb 6, 2018
yegor256#580 Fix failed tests of digest invelope.
59b5ef9 
     Added clear description for TextHasString
@nick318 nick318 mentioned this issue Feb 6, 2018
Merged
nick318 pushed a commit to nick318/cactoos that referenced this issue Feb 6, 2018
yegor256#580 fix warning for static field
fa4e813
nick318 pushed a commit to nick318/cactoos that referenced this issue Feb 6, 2018
yegor256#580 fix cr-lf for different check sums
d028816
nick318 pushed a commit to nick318/cactoos that referenced this issue Feb 7, 2018
yegor256#580 Add unit test for TextHasString
be881bd
@nick318
Copy link

nick318 commented Feb 8, 2018 •
edited
Loading

@yegor256 @llorllale the issue can be closed since #617 is merged

@llorllale
Copy link
Contributor Author

@nick318 thanks! Tests work now on windows

@0crat
Copy link
Collaborator

0crat commented Feb 8, 2018

Order was successfully finished: +30 points just awarded to @Icok/z, total is +45

@0crat
Copy link
Collaborator

0crat commented Feb 8, 2018

The job #580 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug scope
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yegor256 @llorllale @nick318 @0crat