Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#460 Max and Min were renamed to HighestOf and LowestOf to support Comparable implementations #475

Closed
wants to merge 1 commit into from

Conversation

bedward70
Copy link
Contributor

After the discussion "MaxOf and MinOf #460".

To support Comparable implementations:

  1. Max and Min were renamed to HighestOf and LowestOf.
  2. Tests were added for Comparable implementations: String, Character.

@0crat
Copy link
Collaborator

0crat commented Nov 28, 2017

@yegor256 please, pay attention to this pull request

@codecov-io
Copy link

Codecov Report

Merging #475 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #475      +/-   ##
============================================
+ Coverage     65.74%   66.04%   +0.29%     
- Complexity      862      878      +16     
============================================
  Files           178      183       +5     
  Lines          3004     3039      +35     
  Branches        226      230       +4     
============================================
+ Hits           1975     2007      +32     
- Misses          971      974       +3     
  Partials         58       58
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/scalar/LowestOf.java 100% <100%> (ø) 3 <3> (?)
src/main/java/org/cactoos/scalar/Folded.java 100% <100%> (ø) 4 <4> (?)
src/main/java/org/cactoos/func/MaxFunc.java 100% <100%> (ø) 3 <3> (?)
src/main/java/org/cactoos/scalar/HighestOf.java 100% <100%> (ø) 3 <3> (?)
src/main/java/org/cactoos/func/MinFunc.java 100% <100%> (ø) 3 <3> (?)
src/main/java/org/cactoos/func/RetryFunc.java 30.76% <0%> (-11.54%) 3% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89292e...513b908. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Nov 28, 2017

Job gh:yegor256/cactoos#475 is in scope.

@0crat
Copy link
Collaborator

0crat commented Nov 28, 2017

Job gh:yegor256/cactoos#475 assigned to @kkamkou, please go ahead (policy).

@yegor256
Copy link
Owner

@bedward70 why do we need that MaxFunc and MinFunc? Can't we just inline them? Also, we already have Reduced, why adding Folded?

@bedward70
Copy link
Contributor Author

@yegor256 oh, sorry! I'll fix it now!

@bedward70 bedward70 closed this Nov 28, 2017
@0crat
Copy link
Collaborator

0crat commented Nov 28, 2017

Job gh:yegor256/cactoos#475 is now out of scope.

@0crat
Copy link
Collaborator

0crat commented Nov 28, 2017

Payment to ARC for closed pull request.: +15 points just awarded to @yegor256, total is +6285.

@0crat
Copy link
Collaborator

0crat commented Nov 28, 2017

Order was successfully finished: +30 points just awarded to @kkamkou, total is +1530.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants