-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated setRewards #474
Conversation
Hello Also I can see you added a DSstore file that isn't needed |
939d802
to
d8e8bc7
Compare
@pandadefi, I reread your original comment and I now understand what you mean. I have added the modifier _onlyRewarder to require either strategist or goverance and applied this modifier to _setRewards. This has been tested. I ran the python formatter but I was not able to get the solidity lint to run. (If there is any constructive criticism or issues, please comment. I am new to pull requests/contributing and I am trying to learn.) |
All checks have passed, one last change regarding the comment and I will merge. |
Head branch was pushed to by a user without write access
* refactor: reduce base strategy size (#422) * refactor: reduce base strategy size * fix: do not add onlyManagement * fix: allow harvest on add strategy block (#428) * fix: allow harvest on add strategy block * docs: comment Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> * fix: updated setRewards (#474) * feat: add deposit and withdraw events (#499) * feat: add event to add_event_to_setLockedProfitDegradation (#506) * fix: implement modifiers (#513) * fix: implement modifiers * fix: typo * fix: formatting * fix: test same time harvest not allowed * fix: merge mistake * fix: gov event * fix: add pps protection * chore: update solc version * chore: add FeeReport event * chore: update FeeReport * chore: bump vyper version * chore: bump brownie version * test: fixes * chore: bump ganache version * style: fix format * test: airdrop do not change pps * test: make sure deposits are still possible * ci: cancel same branch run * style: fix python formating * fix: wrong math operation * fix: tests * fix: add missing WithdrawFromStrategy event * docs: fix comment * chore: cleanup docs folder * chore: remove not used code * feat: prevent fork replay EIP712 signature (#3) * chore: bump version * fix: clone check (#5) * fix: make sure strategy isn't in emergency mode when updating debt (#4) * fix: change permit definition (#6) * fix: change permit definition * fix: tests * chore: format * fix: do not use external call * fix: allow setEmergency after revoke (#7) Co-authored-by: Steffel <2143646+steffenix@users.noreply.github.com> Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: John Bergschneider <jhb10c@my.fsu.edu> Co-authored-by: jmonteer <68742302+jmonteer@users.noreply.github.com>
This is update was requested in 467.
The contract BaseStrategy has the onlyRewards updated so that only governance can update the address. The corresponding tests have been updated.