-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate list of events #6
Labels
Comments
Vault has:
Vault has (for strategies):
|
Reminder to think of events for
|
I think this can be closed with the addition of the Registry? |
Agree this can be closed now that we have registry |
pandadefi
added a commit
that referenced
this issue
Oct 25, 2022
* refactor: reduce base strategy size (#422) * refactor: reduce base strategy size * fix: do not add onlyManagement * fix: allow harvest on add strategy block (#428) * fix: allow harvest on add strategy block * docs: comment Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> * fix: updated setRewards (#474) * feat: add deposit and withdraw events (#499) * feat: add event to add_event_to_setLockedProfitDegradation (#506) * fix: implement modifiers (#513) * fix: implement modifiers * fix: typo * fix: formatting * fix: test same time harvest not allowed * fix: merge mistake * fix: gov event * fix: add pps protection * chore: update solc version * chore: add FeeReport event * chore: update FeeReport * chore: bump vyper version * chore: bump brownie version * test: fixes * chore: bump ganache version * style: fix format * test: airdrop do not change pps * test: make sure deposits are still possible * ci: cancel same branch run * style: fix python formating * fix: wrong math operation * fix: tests * fix: add missing WithdrawFromStrategy event * docs: fix comment * chore: cleanup docs folder * chore: remove not used code * feat: prevent fork replay EIP712 signature (#3) * chore: bump version * fix: clone check (#5) * fix: make sure strategy isn't in emergency mode when updating debt (#4) * fix: change permit definition (#6) * fix: change permit definition * fix: tests * chore: format * fix: do not use external call * fix: allow setEmergency after revoke (#7) Co-authored-by: Steffel <2143646+steffenix@users.noreply.github.com> Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: John Bergschneider <jhb10c@my.fsu.edu> Co-authored-by: jmonteer <68742302+jmonteer@users.noreply.github.com>
pandadefi
added a commit
to pandadefi/yearn-vaults
that referenced
this issue
Oct 25, 2022
This reverts commit f49101b.
pandadefi
added a commit
that referenced
this issue
Nov 1, 2022
* Revert "fix: change permit definition (#6)" This reverts commit f49101b. * fix: remove unlimited permit approval * fix: tests expiry * feat: update harvestTrigger Update harvestTrigger with base fee oracle, force trigger once, and credit available checks * fix: remove extra harvest that occasionally reverts * feat: always return true if no baseFeeOracle set * fix: add submodule for provider * feat: updates from PR review * fix: weasel suggestions * feat: add more events to baseFeeOracle * fix: add indexing for addresses in basefeeOracle events Co-authored-by: dudesahn <dudesahn@gmail.com>
pandadefi
added a commit
to pandadefi/yearn-vaults
that referenced
this issue
Nov 25, 2022
This reverts commit f49101b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current subgraph is ugly cause there is no standartized way to retrieve parameters.
Filter which parameters are used/useful and introduce corresponding events.
The text was updated successfully, but these errors were encountered: