-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Versioning system to Vaults #3
Comments
This was referenced Oct 14, 2020
Closed
fubuloubu
added a commit
that referenced
this issue
Jan 28, 2021
* fix: too few shares are burned in case of loss w/ adjusted withdrawal Audit Response #2 - 5.1 * fix: check loss protection after adjusting for withdrawal capacity Audit Response #2 - 5.2 * docs: clarify documentation around revoking during emergency exit mode * fix: make expected return 0 if strategy is declaring itself inactive Audit Response #2 - 8.4 * fix: use strategy's lastReport value on migration, not block.timestamp Audit Reponse #2 - 8.5 * fix: increase precision on price calc by 3 places Audit Reponse #2 - 8.7 * refactor: small updates to comments and StrategyAPI functions Audit Response #2 - 5.5 * refactor: improve the accuracy of `expectedReturn` Audit Reponse #2 - 5.6 * docs: clarified requirement for Emergency Shutdown * docs: updated requirement Audit Reponse #2 - 5.12 * fix: add reentrancy guard (using same key as "withdraw") to "deposit" Audit Reponse #2 - 5.19
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this issue
Aug 8, 2021
* fix: too few shares are burned in case of loss w/ adjusted withdrawal Audit Response yearn#2 - 5.1 * fix: check loss protection after adjusting for withdrawal capacity Audit Response yearn#2 - 5.2 * docs: clarify documentation around revoking during emergency exit mode * fix: make expected return 0 if strategy is declaring itself inactive Audit Response yearn#2 - 8.4 * fix: use strategy's lastReport value on migration, not block.timestamp Audit Reponse yearn#2 - 8.5 * fix: increase precision on price calc by 3 places Audit Reponse yearn#2 - 8.7 * refactor: small updates to comments and StrategyAPI functions Audit Response yearn#2 - 5.5 * refactor: improve the accuracy of `expectedReturn` Audit Reponse yearn#2 - 5.6 * docs: clarified requirement for Emergency Shutdown * docs: updated requirement Audit Reponse yearn#2 - 5.12 * fix: add reentrancy guard (using same key as "withdraw") to "deposit" Audit Reponse yearn#2 - 5.19
pandadefi
added a commit
that referenced
this issue
Oct 25, 2022
* refactor: reduce base strategy size (#422) * refactor: reduce base strategy size * fix: do not add onlyManagement * fix: allow harvest on add strategy block (#428) * fix: allow harvest on add strategy block * docs: comment Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> * fix: updated setRewards (#474) * feat: add deposit and withdraw events (#499) * feat: add event to add_event_to_setLockedProfitDegradation (#506) * fix: implement modifiers (#513) * fix: implement modifiers * fix: typo * fix: formatting * fix: test same time harvest not allowed * fix: merge mistake * fix: gov event * fix: add pps protection * chore: update solc version * chore: add FeeReport event * chore: update FeeReport * chore: bump vyper version * chore: bump brownie version * test: fixes * chore: bump ganache version * style: fix format * test: airdrop do not change pps * test: make sure deposits are still possible * ci: cancel same branch run * style: fix python formating * fix: wrong math operation * fix: tests * fix: add missing WithdrawFromStrategy event * docs: fix comment * chore: cleanup docs folder * chore: remove not used code * feat: prevent fork replay EIP712 signature (#3) * chore: bump version * fix: clone check (#5) * fix: make sure strategy isn't in emergency mode when updating debt (#4) * fix: change permit definition (#6) * fix: change permit definition * fix: tests * chore: format * fix: do not use external call * fix: allow setEmergency after revoke (#7) Co-authored-by: Steffel <2143646+steffenix@users.noreply.github.com> Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: John Bergschneider <jhb10c@my.fsu.edu> Co-authored-by: jmonteer <68742302+jmonteer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Gnosis Safe uses
VERSION
idempotent storage variableAlso, figure out if there's a way we can use proxies smartly?
The text was updated successfully, but these errors were encountered: