Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to configure min alloc size #7951

Merged

Conversation

gridnevvvit
Copy link
Member

Changelog entry

currently mkql allocator makes requests by chunks of 30MiB minimum, so making that configurable and changing that limit to 8MiB.

also minimal 'free' quota is 1MiB because of alignment rules (mkql aligns in 1MiB)

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 19:12:04 UTC Pre-commit check for 0883e0b has started.
2024-08-16 19:15:52 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-16 20:49:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40349 34998 0 4 5309 38

2024-08-16 20:53:04 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-16 21:02:51 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 21 0 0 0 27

🟢 2024-08-16 21:02:59 UTC Build successful.
🔴 2024-08-16 21:03:32 UTC ydbd size 8.1 GiB changed* by +2.2 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 28512db merge: 0883e0b diff diff %
ydbd size 8 732 888 200 Bytes 8 735 237 016 Bytes +2.2 MiB +0.027%
ydbd stripped size 475 301 512 Bytes 475 370 920 Bytes +67.8 KiB +0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 19:13:17 UTC Pre-commit check for 0883e0b has started.
2024-08-16 19:17:31 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-16 19:55:55 UTC Build successful.

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 19:35:25 UTC Pre-commit check for 0883e0b has started.
2024-08-16 19:38:24 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-16 22:07:49 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11485 11413 0 18 23 31

🟢 2024-08-16 22:08:53 UTC Build successful.
🟡 2024-08-16 22:09:24 UTC ydbd size 5.5 GiB changed* by +1.7 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8dc96f7 merge: 0883e0b diff diff %
ydbd size 5 877 295 352 Bytes 5 879 078 896 Bytes +1.7 MiB +0.030%
ydbd stripped size 1 476 632 880 Bytes 1 476 955 248 Bytes +314.8 KiB +0.022%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 05367f9 into ydb-platform:main Aug 19, 2024
11 of 13 checks passed
@gridnevvvit gridnevvvit deleted the allow-to-configure-min-alloc-size branch August 19, 2024 09:31
gridnevvvit added a commit to gridnevvvit/ydb that referenced this pull request Aug 19, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants