Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to configure min alloc size (#7951) #7996

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

gridnevvvit
Copy link
Member

Changelog entry

currently mkql allocator makes requests by chunks of 30MiB minimum, so making that configurable and changing that limit to 8MiB.

also minimal 'free' quota is 1MiB because of alignment rules (mkql aligns in 1MiB)

Changelog category

  • Improvement

Additional information

...

@gridnevvvit gridnevvvit requested a review from a team as a code owner August 19, 2024 10:00
Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 10:04:05 UTC Pre-commit check for 5d09c23 has started.
2024-08-19 10:06:47 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-19 10:36:00 UTC Build successful.

Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 10:04:15 UTC Pre-commit check for 5d09c23 has started.
2024-08-19 10:07:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-19 11:04:36 UTC Build successful.
2024-08-19 11:04:53 UTC Tests are running...
🔴 2024-08-19 12:48:56 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39792 34567 0 2 5213 10

🟢 2024-08-19 12:49:35 UTC ydbd size 8.1 GiB changed* by +18.7 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: e7ccd59 merge: 5d09c23 diff diff %
ydbd size 8 724 471 240 Bytes 8 724 490 424 Bytes +18.7 KiB +0.000%
ydbd stripped size 476 926 664 Bytes 476 930 856 Bytes +4.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 10:04:19 UTC Pre-commit check for 5d09c23 has started.
2024-08-19 10:07:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-19 10:48:12 UTC Build successful.
2024-08-19 10:48:27 UTC Tests are running...
🔴 2024-08-19 12:40:00 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11244 11197 0 8 27 12

🟢 2024-08-19 12:40:45 UTC ydbd size 5.5 GiB changed* by +15.0 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: e7ccd59 merge: 5d09c23 diff diff %
ydbd size 5 904 613 600 Bytes 5 904 628 960 Bytes +15.0 KiB +0.000%
ydbd stripped size 1 480 290 208 Bytes 1 480 294 944 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 4a7f723 into ydb-platform:stable-24-3 Aug 19, 2024
11 of 16 checks passed
@gridnevvvit gridnevvvit deleted the merge-changes branch August 30, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants