Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ-3568 fix error sent large get operation #8035

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Aug 20, 2024

Changelog entry

Fixed error sent large get operation

Changelog category

  • Bugfix

Additional information

Added ast truncating in get operation, current size:

  • Plan <= 16MB
  • Issues <= 16MB
  • Ast - truncated to Plan + Ast <= 40MB

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 04:21:43 UTC Pre-commit check for 18215fc has started.
2024-08-20 04:24:22 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-20 04:40:59 UTC Build successful.

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 04:22:04 UTC Pre-commit check for 18215fc has started.
2024-08-20 04:24:49 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-20 06:41:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10093 9998 0 25 31 39

🟢 2024-08-20 06:42:16 UTC Build successful.
🟢 2024-08-20 06:42:47 UTC ydbd size 5.5 GiB changed* by +17.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0abac7 merge: 18215fc diff diff %
ydbd size 5 886 490 344 Bytes 5 886 507 760 Bytes +17.0 KiB +0.000%
ydbd stripped size 1 478 181 008 Bytes 1 478 183 568 Bytes +2.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 04:24:39 UTC Pre-commit check for 18215fc has started.
2024-08-20 04:27:27 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-20 05:50:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14282 12898 0 5 1340 39

2024-08-20 05:51:22 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-20 06:01:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
57 (only retried tests) 29 0 1 0 27

2024-08-20 06:01:35 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-20 06:08:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 (only retried tests) 16 0 0 0 27

🟢 2024-08-20 06:08:52 UTC Build successful.
🟢 2024-08-20 06:09:37 UTC ydbd size 8.1 GiB changed* by +13.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0abac7 merge: 18215fc diff diff %
ydbd size 8 747 173 072 Bytes 8 747 187 144 Bytes +13.7 KiB +0.000%
ydbd stripped size 475 745 960 Bytes 475 746 856 Bytes +896 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA force-pushed the YQ-3568-fix-error-sent-large-get-operation branch from b44dd91 to c09b6b2 Compare August 20, 2024 07:03
Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 07:06:51 UTC Pre-commit check for c2e3980 has started.
2024-08-20 07:09:34 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-20 07:14:49 UTC Build successful.

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 07:06:55 UTC Pre-commit check for c2e3980 has started.
2024-08-20 07:09:42 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-20 07:19:37 UTC Check cancelled

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 07:06:57 UTC Pre-commit check for c2e3980 has started.
2024-08-20 07:09:51 UTC Check linux-x86_64-release-asan is running...
2024-08-20 07:19:31 UTC Check cancelled

@GrigoriyPA GrigoriyPA requested a review from dorooleg August 20, 2024 07:19
Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 07:21:10 UTC Pre-commit check for bc71058 has started.
2024-08-20 07:25:46 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-20 09:26:59 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9946 9855 0 20 30 41

🟢 2024-08-20 09:27:52 UTC Build successful.
🟢 2024-08-20 09:28:23 UTC ydbd size 5.5 GiB changed* by +19.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0abac7 merge: bc71058 diff diff %
ydbd size 5 886 490 344 Bytes 5 886 510 440 Bytes +19.6 KiB +0.000%
ydbd stripped size 1 478 181 008 Bytes 1 478 184 144 Bytes +3.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 07:22:54 UTC Pre-commit check for bc71058 has started.
2024-08-20 07:25:36 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-20 07:30:35 UTC Build successful.

Copy link

github-actions bot commented Aug 20, 2024

2024-08-20 07:23:00 UTC Pre-commit check for bc71058 has started.
2024-08-20 07:25:39 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-20 08:40:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14138 12760 0 4 1341 33

2024-08-20 08:41:42 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-20 08:48:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 24 0 0 0 27

🟢 2024-08-20 08:48:53 UTC Build successful.
🟢 2024-08-20 08:49:24 UTC ydbd size 8.1 GiB changed* by +15.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b0abac7 merge: bc71058 diff diff %
ydbd size 8 747 173 072 Bytes 8 747 188 760 Bytes +15.3 KiB +0.000%
ydbd stripped size 475 745 960 Bytes 475 746 984 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 7cf4051 into ydb-platform:main Aug 20, 2024
10 of 12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3568-fix-error-sent-large-get-operation branch August 20, 2024 10:35
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 21, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants