dq_input_transform_lookup: fix indexes for left-side lookup key #7727

yumkam · 2024-08-13T13:40:24Z

Changelog entry

...

Changelog category

Bugfix
Not for changelog (changelog entry is not required)

Additional information

leftJoinColumnIndexes should've been indexes into input row, not into left-side key fields

github-actions · 2024-08-13T13:43:18Z

⚪ 2024-08-13 13:43:17 UTC Pre-commit check for d70e564 has started.
⚪ 2024-08-13 13:46:07 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-13 16:47:58 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9565	9528	0	3	22	12

🟢 2024-08-13 16:49:05 UTC Build successful.
🟢 2024-08-13 16:49:35 UTC ydbd size 5.4 GiB changed* by +14.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `e0e98b1`	merge: `d70e564`	diff	diff %
ydbd size	5 851 479 824 Bytes	5 851 494 424 Bytes	+14.3 KiB	+0.000%
ydbd stripped size	1 469 374 288 Bytes	1 469 378 064 Bytes	+3.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-13T13:44:54Z

⚪ 2024-08-13 13:44:54 UTC Pre-commit check for d70e564 has started.
⚪ 2024-08-13 13:48:16 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-13 13:53:19 UTC Build successful.

github-actions · 2024-08-13T13:52:26Z

⚪ 2024-08-13 13:52:26 UTC Pre-commit check for d70e564 has started.
⚪ 2024-08-13 13:55:37 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-13 15:32:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38203	32878	0	2	5308	15

⚪ 2024-08-13 15:37:53 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-13 15:46:51 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19 (only retried tests)	9	0	0	0	10

🟢 2024-08-13 15:46:57 UTC Build successful.
🟢 2024-08-13 15:47:20 UTC ydbd size 8.1 GiB changed* by +18.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `e0e98b1`	merge: `d70e564`	diff	diff %
ydbd size	8 700 604 288 Bytes	8 700 623 504 Bytes	+18.8 KiB	+0.000%
ydbd stripped size	473 093 896 Bytes	473 095 112 Bytes	+1.2 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

yumkam · 2024-08-13T16:40:47Z

passes upcoming tests from #7568

ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp

github-actions · 2024-08-14T12:08:47Z

⚪ 2024-08-14 12:08:47 UTC Pre-commit check for 1a632e1 has started.
⚪ 2024-08-14 12:11:39 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 14:31:21 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9608	9525	0	22	27	34

🟢 2024-08-14 14:32:31 UTC Build successful.
🟢 2024-08-14 14:33:02 UTC ydbd size 5.5 GiB changed* by +14.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b6537e1`	merge: `1a632e1`	diff	diff %
ydbd size	5 869 833 096 Bytes	5 869 847 704 Bytes	+14.3 KiB	+0.000%
ydbd stripped size	1 473 498 160 Bytes	1 473 501 936 Bytes	+3.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-14T12:22:28Z

⚪ 2024-08-14 12:22:28 UTC Pre-commit check for 1a632e1 has started.
⚪ 2024-08-14 12:26:28 UTC Check linux-x86_64-relwithdebinfo is running...

github-actions · 2024-08-14T12:29:58Z

⚪ 2024-08-14 12:29:58 UTC Pre-commit check for 1a632e1 has started.
⚪ 2024-08-14 12:33:36 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-14 12:38:16 UTC Build successful.

github-actions · 2024-08-15T09:28:07Z

⚪ 2024-08-15 09:28:07 UTC Pre-commit check for 41ae0f9 has started.
⚪ 2024-08-15 09:30:49 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-15 10:45:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38263	32913	0	3	5309	38

⚪ 2024-08-15 10:48:13 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-15 10:55:14 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
53 (only retried tests)	25	0	0	0	28

🟢 2024-08-15 10:55:22 UTC Build successful.
🟢 2024-08-15 10:56:08 UTC ydbd size 8.1 GiB changed* by +18.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `34ca76d`	merge: `41ae0f9`	diff	diff %
ydbd size	8 731 641 184 Bytes	8 731 660 360 Bytes	+18.7 KiB	+0.000%
ydbd stripped size	475 247 496 Bytes	475 248 712 Bytes	+1.2 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-15T09:29:27Z

⚪ 2024-08-15 09:29:27 UTC Pre-commit check for 41ae0f9 has started.
⚪ 2024-08-15 09:32:07 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 09:36:41 UTC Build successful.

github-actions · 2024-08-15T09:34:42Z

⚪ 2024-08-15 09:34:42 UTC Pre-commit check for 41ae0f9 has started.
⚪ 2024-08-15 09:37:21 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 11:37:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9601	9536	0	10	22	33

🟢 2024-08-15 11:38:03 UTC Build successful.
🟢 2024-08-15 11:38:33 UTC ydbd size 5.5 GiB changed* by +14.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `34ca76d`	merge: `41ae0f9`	diff	diff %
ydbd size	5 877 727 432 Bytes	5 877 741 984 Bytes	+14.2 KiB	+0.000%
ydbd stripped size	1 476 694 320 Bytes	1 476 698 032 Bytes	+3.6 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

…platform#7727) (cherry picked from commit bce790f)

…platform#7727)

yumkam requested a review from zverevgeny August 13, 2024 13:40

github-actions bot added the bugfix label Aug 13, 2024

yumkam marked this pull request as ready for review August 13, 2024 16:38

yumkam requested review from a team as code owners August 13, 2024 16:39

zverevgeny reviewed Aug 14, 2024

View reviewed changes

ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp Outdated Show resolved Hide resolved

zverevgeny previously approved these changes Aug 14, 2024

View reviewed changes

yumkam dismissed zverevgeny’s stale review via e4f7525 August 14, 2024 12:00

yumkam added 2 commits August 15, 2024 12:22

dq_input_transform_lookup: fix indexes for left-side lookup key

108f830

fix review comments

55ffe1e

yumkam force-pushed the fix-streamlookup-input-indexes branch from e4f7525 to 55ffe1e Compare August 15, 2024 09:23

yumkam requested a review from zverevgeny August 15, 2024 12:18

zverevgeny approved these changes Aug 15, 2024

View reviewed changes

yumkam requested a review from rvu1024 August 15, 2024 14:38

rvu1024 approved these changes Aug 16, 2024

View reviewed changes

rvu1024 merged commit bce790f into ydb-platform:main Aug 16, 2024
10 of 12 checks passed

This was referenced Aug 19, 2024

YQ-3154 improve error in s3 applicator actor #7976

Merged

YQ-3566 fix sql injection in create binding request #7984

Merged

YQ-3570 added s3 wildcards validations #8017

Merged

YQ-3568 fix error sent large get operation #8035

Merged

This was referenced Aug 21, 2024

YQ-3363 fix internal error for insert without params #8074

Merged

YQ kqprun enable runtime listing by default #8096

Merged

yumkam added a commit to yumkam/ydb that referenced this pull request Aug 26, 2024

dq_input_transform_lookup: fix indexes for left-side lookup key (ydb-…

735d915

…platform#7727) (cherry picked from commit bce790f)

niksaveliev mentioned this pull request Aug 29, 2024

Fix pqv1 max partitions #8485

Merged

stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024

dq_input_transform_lookup: fix indexes for left-side lookup key (ydb-…

e727e0a

…platform#7727)

This was referenced Sep 9, 2024

Fix CLI max partitions default #8944

Merged

Fix reading without consumer from federation #9136

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dq_input_transform_lookup: fix indexes for left-side lookup key #7727

dq_input_transform_lookup: fix indexes for left-side lookup key #7727

yumkam commented Aug 13, 2024

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

yumkam commented Aug 13, 2024

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

dq_input_transform_lookup: fix indexes for left-side lookup key #7727

dq_input_transform_lookup: fix indexes for left-side lookup key #7727

Conversation

yumkam commented Aug 13, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 • edited Loading

yumkam commented Aug 13, 2024

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 15, 2024 • edited Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024 •

edited

Loading